https://pantsbuild.org/ logo
#development
Title
# development
h

hundreds-father-404

06/17/2022, 6:02 PM
With the
run
PR https://github.com/pantsbuild/pants/pull/15849,
[python].tailor_pex_binary_targets
is no longer very useful. Thoughts on what should happen? cc @happy-kitchen-89482
🎉 1
Related,
pex_binaries
seems less useful. There is some complexity to keeping it around, like that the generated addresses are more complex. More to document. cc @bitter-ability-32190
b

bitter-ability-32190

06/17/2022, 6:05 PM
I have a real world use case of using the generator for real package-ables, but I can get away with one per 🤷‍♂️
h

hundreds-father-404

06/17/2022, 6:17 PM
With Andreas's new
__defaults__
, is it still helpful for you to have?
b

bitter-ability-32190

06/17/2022, 6:30 PM
Yeah. It's multiple binaries in a dir,
w

witty-crayon-22786

06/17/2022, 6:51 PM
pex_binaries can probably already be replaced with parametrize
🤔 1
b

bitter-ability-32190

06/17/2022, 7:02 PM
That's true. Although it's asymmetrical to the other generator targets. And wouldn't work for the overrides field, right?
w

witty-crayon-22786

06/17/2022, 7:03 PM
Yea, wouldn't have overrides
b

bitter-ability-32190

06/17/2022, 7:05 PM
It really is multiple binaries so a generator is most correct here
1
h

hundreds-father-404

06/17/2022, 7:34 PM
Yeah I think it's fine if we want to keep the generator. It's a valid use of the mechanism
Sounds like everyone agrees on getting rid of
tailor
for
pex_binary
though? I'm not sure how we deprecate that. it would be annoying to require people to explicitly set it in order to change the default w/o breaking deprecation policy
1
b

bitter-ability-32190

06/17/2022, 8:00 PM
Depreciation warning if the python option for tailoring PEX binary is true?
Oh I guess that's the default. I think that's ok to deprecate and warn. Maybe only if we end up tailoring a pex binary?
h

happy-kitchen-89482

06/17/2022, 9:31 PM
I don't know that I agree about getting rid of `tailor`ing pex_binary
Or are you suggesting changing the default?
but keeping the capability
b

bitter-ability-32190

06/17/2022, 10:09 PM
To me, it's kind of like the infer init thing. Some python scripts are just scripts and some are real applications to package. If someone turns on tailor how do we ensure we don't blast their scripts as binaries?
Which doesn't say whether we should deprecate or not. Just highlighting a fhallenge
h

happy-kitchen-89482

06/17/2022, 11:37 PM
Yeah
Hmm