https://pantsbuild.org/ logo
Join Slack
Powered by
What's the protocol re CI for docs only changes?
# development
h
What's the protocol re CI for docs only changes?
Re the new in-repo docsite sources I mean
h
we want to improve it so that CI automatically skips, but haven't had the time to implement that
h
Right now we appear to run CI, which seems unnecessary and wasteful?
Ah OK, so manually skip it?
h
CI must pass to merge, so you can't manually skip
if you have the time, it would be great to implement - but we want to do it ideally by using Github Action's skip mechanism based on file paths
👀 1
h
I can merge without CI as an admin ... 😱
❗ 1
Also probably after merging to a stable branch the CI should actually sync to readme.com!
But one thing at a time
h
h
AFAICT GHA's skip mechanism just skips the run, it doesn't exempt the PR from the checks it skipped...
"If a workflow is skipped due to path filtering, branch filtering or a commit message (see below), then checks associated with that workflow will remain in a "Pending" state. A pull request that requires those checks to be successful will be blocked from merging."
So we'll have to do something else
Ah, I guess we can create a no-op workflow with the same name
Since check validation is done by name
b
Or skip all the steps of the workflow?
h
That's the problem, not the solution.
We have branch protection rules that require various named workflows to pass to allow a merge
skipping the workflow doesn't exempt the PR from those rules
So merging will be disallowed
b
Don't skip the workflow, just skip the steps/job inside the workflow
Both Jobs and steps have 
if
IIRC
👍 1
h
Ah, I see
Yeah but then every single thing in the workflow needs that condition, which seems complex
b
☝️ Good point
If a workflow has one job, thats easy I suppose, N jobs is less so
Open in Slack
PreviousNext
Powered by