https://pantsbuild.org/ logo
Join Slack
Powered by
i’m going to cut 2.11/2.12/2.13 releases later thi...
# development
w
i’m going to cut 2.11/2.12/2.13 releases later this afternoon: if you need anything in 2.13, let me know and i’ll wait. if you need anything in 2.11 or 2.12… let’s discuss
f
2.13rc or final?
w
rc
f
okay then I can wait, I’ll probably want any metrics-related PRs picked to 2.13.
w
…hm, and actually: there are a ton of picks that need to go in too.
f
(but of course they will need to land on main in the next day or so)
b
guilty 🙈 I can pick my own if needbe 🙂
w
@bitter-ability-32190: if you have a sec, yea: that would be great.
b
Ideally we get https://github.com/pantsbuild/pants/pull/15962 and https://github.com/pantsbuild/pants/pull/15849 in. The integration tests are lengthy so feedback is slow 😅
w
yea. this probably won’t be the last 2.13 rc either.
@fast-nail-55400: ditto your picks if you have time.
f
(needs approval)
w
fwiw: you can use 
build-support/bin/cherry_pick.sh 15975 2.13.x
to help with the pick in future
f
ah cool TIL
w
(thanks Josh!)
🙌 1
b
@witty-crayon-22786 I'm gonna land mine sequentially, since the code relies on that
👍 1
h
@witty-crayon-22786 I think we should call 2.13 release tomorrow 
.a1
, given that Josh still needs to land the 
run
changes. I didn't have time today to review
it will be an API change, so it's not really an rc
w
hm. maybe. we haven’t actually prepped a 2.13, so if @bitter-ability-32190 lands those first thing tomorrow, we could still prep rc0.
👍 1
but i’m not 100% certain about using 
a
releases that way either… i had been thinking that they were more exceptional
b
Sorry I was late to work on that change 🙈 Primed and ready to merge on command (or address feedback)
Whoever wants can merge https://github.com/pantsbuild/pants/pull/15988 when green, otherwise I'll get to it ASAP tomorrow morning
OK I'm caught up cherry-picking my merged PRs, still the 2 open ones
w
ok: all closed 
needs-cherrypick
items have PRs out: i’ll be tied up for the next two hours, but then let’s talk about 
a
vs 
rc
👍 1
i’ve prepared 
rc0
: if we think it should be 
a1
instead, let me know. https://github.com/pantsbuild/pants/pull/16010
f
I vote we should stay consistent with the new alpha release system so 
a0
h
*a1
f
ah we already did 
a0
w
yea, sorry. my bad.
h
I just reviewed the major last change from @bitter-ability-32190. Josh, are you around to fix that up so we can merge. Sorry for my delay reviewing and that it's after hours in Texas. No rush, we can get it tomorrow
f
we had a bunch of stuff cherry-picked in last day, I vote 
a1
➕ 1
h
Yeah, I'm pro a1 too
w
this is grey area… i put “extenuating circumstances” in there for the motivation for having alpha releases.
it seems like the motivation in this case is “we’re cherry-picking features, rather than bugfixes”…?
➕ 1
h
yeah, particularly *disruptive features and User API changes
w
k.
so: extenuating, but the extenuating bit was that we’re cherry-picking risky features.
➕ 1
h
rc0 to me means "we think there's reliable stability". Here, 
run
could be disruptive, even though Josh did a great job imo minimizing it
fyi I really wanted to get in a 
tailor
change for 
__init__.py
files that we had to revert due to a flaky test. I think that is lower risk, so fine in rc0
all subjective 🙂
w
i’m headed out, but will set auto-merge
h
i can take over also 🙂
weird hours for me, I'll probably work a little more this evening
w
I might take you up on that, yea... We're mostly packed, but still some stuff to do before we leave tomorrow afternoon
❤️ 1
b
I'm around
w
@hundreds-father-404: the 
2.13.0a1
notes landed on 
main
: do you want to take over doing the release and doing additional cherrypicks if that’s what you’ve decided?
h
yes, we need to cherry-pick Josh's PRs first and fix the changelog
b
I'm trying to get my stuff in but the build is holding me back 😭
w
so, to be crystal clear: Eric is going to drive the 
a1
release, yea?
b
(I just merged 
main
back into https://github.com/pantsbuild/pants/pull/15962 and trying CI. I still owe a changelog PR if Eric doesn't beat me to it. Sorry for delay work's busy + the CI issue made this slow)
w
no rush as long as someone owns it! i’m going to be disappearing entirely at 1pm PT 😃
b
👻
w
July 4th camping trip… woot.
h
I was going to, but I've been out sick the past few hours 😞 woke up freezing even after 3 coats and with a cough
@bitter-ability-32190 would you be around? What's left is the cherry-picks, including if you're willing the Go env var one. And updating the changelog
f
@hundreds-father-404: if you want to walk me through doing a release, I can do some of that work since Stu is out and your sick
❤️ 1
b
I can do the cherries and changelog
❤️ 1
h
1. cherry-pick the 2 PRs to 2.13.x 2. have a PR on main that fixes the changelog to have the 3 new changes since release prep landed. Probably easiest to manually generate 3. cherry-pick the main release prep, then the followup changelog PR 4. hand it over to a releaser like me to run the script
f
re (2) and remove the entry for my change that was reverted
👍 1
b
https://github.com/pantsbuild/pants/runs/7135981279?check_suite_focus=true `no method named 
iter
found for opaque type 
impl Iterator<Item = &OsString>
in the current scope` uh oh
@hundreds-father-404 I fixed the build failure on https://github.com/pantsbuild/pants/pull/16018 (cherry-pick of run) and marked it ready for review. Good to merge when gree?
h
yeah, thanks friend
✅ 1
🙌 1
b
h
Thanks! And let's skip the Go env var change - it's not green and I'm too under the weather to help stabilize it & cp @bitter-ability-32190 now that I merged your two CPs, the steps are: 1. CP Stu's release prep. You can do this directly w/o a PR technically, we make an exception for changelog prep 2. CP your update to the release prep. I'm fine also doing it w/o a PR 3. Ping me or another releaser like Benjy to push a commit bumping the version and running release script
b
1 + 2 are done
❤️ 1
h
Excellent, I just pushed the version bump. So when the wheels are built in 1 hour, a releaser just needs to run 
build-support/bin/release.sh publish
. I'll do M1 wheel now so I'm free to go back to resting
😴 1
e
Ah, ok. I'll finish the release.
b
Truly a relay
Open in Slack
PreviousNext
Powered by