https://pantsbuild.org/ logo
Powered by
w

witty-crayon-22786

07/13/2022, 5:53 PM
@flat-zoo-31952: new thread re: https://github.com/pantsbuild/pants/issues/16122
f

flat-zoo-31952

07/13/2022, 5:55 PM
Unset
w

witty-crayon-22786

07/13/2022, 5:55 PM
it’s deprecated in 2.13, so you should be seeing a deprecation
oh, sorry… no. if unset, no deprecation warning. and we changed the default. hm.
f

flat-zoo-31952

07/13/2022, 5:59 PM
Reminder that I'm using a single build file to declare 99% of my targets with recursive globs. I think I've managed to cut the time down dramatically by changing to 111 in a dev branch
Can confirm that and profile it later
w

witty-crayon-22786

07/13/2022, 6:00 PM
do any of the targets have a lot of sources globs?
…oh. i think i see it.
f

flat-zoo-31952

07/13/2022, 6:45 PM
Unset and no I haven't
w

witty-crayon-22786

07/13/2022, 6:45 PM
ok. to confirm a theory, could you try again with 
--python-infer-init-files=never
?
f

flat-zoo-31952

07/13/2022, 7:02 PM
Yeah I can try. Probably not until later or tomorrow morning though
Anecdotally I saw a lot of notes about inferring init files in the suspected problem zone when I was going through logs
w

witty-crayon-22786

07/13/2022, 7:10 PM
yea. i think i have a solid hypothesis, but that would confirm it. will comment on the ticket.
once you confirm the hypothesis, i’ve sketched out a fix on the ticket that we can get someone on. but there is a ton going on right now, so i’ll probably wait until you confirm to do that.
f

flat-zoo-31952

07/13/2022, 10:04 PM
confirmed, that drops the command time to 28s
w

witty-crayon-22786

07/13/2022, 10:04 PM
darn. well then i guess deferring didn’t save me much time =)
f

flat-zoo-31952

07/13/2022, 10:05 PM
or, 
--python-infer-init-files=content_only
results in a performance regression of >= 200% in my case
it's a huge difference
w

witty-crayon-22786

07/13/2022, 10:05 PM
yea. so… given that you have a workaround, what is the priority of this one for you…?
do you actually have 
__init__.py
files with content?
f

flat-zoo-31952

07/13/2022, 10:06 PM
what's the consequence of leaving that at 
never
? I didn't fully get what that option does from the description
yes sometimes
w

witty-crayon-22786

07/13/2022, 10:07 PM
it will infer deps on parent 
__init__.py
files, such that 
./pants dependencies $file
actually reports them, regardless of whether you have 
imports
to load particular symbols from them
i think that it is only relevant if the 
__init__,py
files have load-time side-effects…? but don’t quote me on that.
f

flat-zoo-31952

07/13/2022, 10:10 PM
So yeah we can probably get away with this, at least until I have the training done enough to move to 111
I'll check in more detail tomorrow
👍 1
If I spend too much time looking like I'm concentrating hard at the computer while on vacation, my wife gets annoyed 😅
In any case, thanks for narrowing this down, real big help
w

witty-crayon-22786

07/13/2022, 10:13 PM
sure thing.
enjoy your vacation!
3 Views
Powered by