Actually on the mypy cache, we can skip mtime chec...
# development
b
Actually on the mypy cache, we can skip mtime checks, which makes a named cache possible... 🧵
3
main
after touching a single file and checking it:
Copy code
LOG:  Build finished in 3.553 seconds with 236 modules, and 0 errors
with my changes:
Copy code
LOG:  Build finished in 0.497 seconds with 236 modules, and 0 errors
@witty-crayon-22786 mypy appears to be atomic in writing of the cache files. So
cache_dir = f".cache/mypy_cache/{hash(build_root.path)}"
is basically all we need 😮 Obviously we should make sure we aren't making bad assumptions but 🎉
w
lol
well then!
😂 2
b
Now I'm even more motivated to remove pylint from my repo
w
(meanwhile! 90% chance of an append-only cache bug over in https://pantsbuild.slack.com/archives/C046T6T9U/p1658412143380059 … they’re scary, but i think that we probably understand this usecase well enough to use them by default)
b
I'll get a PR next time I'm working on stuff