hey folks

Question

hey folks <https github com pantsbuild pants pull 15958|this MR> has been sitting around for a few weeks now I ve rebased and did a bit of cleanup What s the next step for it Is there something I still need to do

wide-midnight-78598 · Answer

At the very least you could add a couple more reviewers I typically add 3 people to increase the chance that someone has time to review

careful-address-89803 · Answer

oh I m supposed to add the reviewers myself How do I know who to add

careful-address-89803 · Answer

also it doesn t look like the add reviewer widget is available for me I was hoping GitHub would suggest the folks who recently modified it

wide-midnight-78598 · Answer

Oh Interesting I didn t know that umm < hundreds father 404>

wide-midnight-78598 · Answer

Github is recommending Eric and Josh Cannon to me because they recently edited those files but that might have just been during API re factoring not necessarily because they worked on Terraform stuff

careful-address-89803 · Answer

`git shortlog n s src python pants backend terraform src python pants backend experimental terraform` shows Eric Tom Josh Cannon and Stu

happy-kitchen-89482 · Answer

Oh sorry about that Thanks for the reminder

happy-kitchen-89482 · Answer

I ll take a look