https://pantsbuild.org/ logo
#development
Title
# development
c

careful-address-89803

07/28/2022, 1:03 AM
hey folks, this MR has been sitting around for a few weeks now. I've rebased and did a bit of cleanup. What's the next step for it? Is there something I still need to do?
w

wide-midnight-78598

07/28/2022, 2:09 AM
At the very least, you could add a couple more reviewers - I typically add 3 people, to increase the chance that someone has time to review
c

careful-address-89803

07/28/2022, 2:14 AM
oh, I'm supposed to add the reviewers myself? How do I know who to add?
also it doesn't look like the "add reviewer" widget is available for me. I was hoping GitHub would suggest the folks who recently modified it.
w

wide-midnight-78598

07/28/2022, 3:42 AM
Oh! Interesting. I didn't know that, umm.... @hundreds-father-404 ?
Github is recommending Eric and Josh Cannon to me because they "recently edited" those files, but that might have just been during API re-factoring, not necessarily because they worked on Terraform stuff
c

careful-address-89803

07/28/2022, 3:56 AM
git shortlog -n -s -- ./src/python/pants/backend/terraform/ ./src/python/pants/backend/experimental/terraform
shows Eric, Tom, Josh Cannon, and Stu
h

happy-kitchen-89482

07/28/2022, 4:53 AM
Oh, sorry about that! Thanks for the reminder
I'll take a look
❤️ 1