https://pantsbuild.org/ logo
Join Slack
Powered by
as much as i hate churn, it just occurred to me th...
# development
w
as much as i hate churn, it just occurred to me that if our 
category
labels where string tags in the description of a PR, submitters could change them themselves, and we wouldn’t need to hit github for log generation, etc
h
True. I think it's nice being able to GitHub search for the labels though
✅ 1
w
You can search the bodies of PRs
h
And I agree w/ @bitter-ability-32190’s suggestion to start using those labels on tickets more. For example, we have both 
category:documentation
and 
documentation
-- those should be merged
b
There's other knobs/levers. I've wanted us to have a nice little GHA-based chatbot. That could manage labels. It could also do merging, and copy the label into commit message and (gasp!) also copy the PR body as well 😛
👍 1
Not saying we should jump there, but just introducing new ideas 🙂 I love automation 🙂
h
The labels are nice because they are a fixed set, whereas remembering which of 7 magic strings I need to stick in the PR description, and in what exact format, is annoying.
➕ 2
Not sure hitting github API for labels is particularly onerous? You don’t even need to be authed
w
you sortof do. otherwise you get ratelimited (see)
h
Has this been happening?
w
yes.
but we adjusted the releaser instructions, which resolved that
h
Ah, good
w
but yes, agreed that more automation is a higher priority. using a merge queue bot like the rust community does with `bors`/`homu` would be interesting.
b
bors
has its thorns as I've found out 😞
w
i could believe it.
that’s the downside of automation: most of it is homegrown and highly specialized
b
You have to choose between Squash-merge-but-all-PRs-are-"closed, not merged", or "PR commits are preserved when merging" 😢 https://forum.bors.tech/t/use-a-squash-merge-in-bors/349/20 GitHub Feature Request: https://github.com/community/community/discussions/12437
❗ 1
Automated bots are fun though. And, like everything else I advocate for, can have punny names. At McD We had "Officer Big Mac", and at IBM I've created "OctoBee" 🙂
Open in Slack
PreviousNext
Powered by