well, dang. it looks like converting `Platform`/`E...
# developmentw
witty-crayon-22786
08/29/2022, 10:25 PMwell, dang. it looks like converting `Platform`/`EnvironmentMatcher` into a parameter in https://github.com/pantsbuild/pants/pull/16682 runs smack into https://github.com/pantsbuild/pants/issues/12934#issuecomment-1049203868: basically, almost all real world
@unionEnvironmentMatcherh
hundreds-father-404
08/29/2022, 10:27 PMbasically, almost all real world @union usage now requires an EnvironmentMatcher to be part of its interface.How come?
w
witty-crayon-22786
08/29/2022, 10:27 PMthinking out loud, but: i’ll either need to adjust the definition of unions to make that explicit, or … hack around it in some way.
h
hundreds-father-404
08/29/2022, 10:28 PMmake what explicit though? I'm not following why unions are a problem
w
witty-crayon-22786
08/29/2022, 10:28 PMthe implementation of https://github.com/pantsbuild/pants/pull/12966 was to convert all
@unionGet(X, Y(..))QueryRule(X, [Y])witty-crayon-22786
08/29/2022, 10:29 PMin that example, that means that nothing other than
Yh
hundreds-father-404
08/29/2022, 10:29 PMahhhh
w
witty-crayon-22786
08/29/2022, 10:29 PMand https://github.com/pantsbuild/pants/pull/16682 wants a new thing to be in scope
witty-crayon-22786
08/29/2022, 10:30 PM…so actually, yea: two options then.
1. adjust all plugin callsites to explicitly re-pass the EnvironmentMatcher like
await Get(Output, {input: Input, env_matcher: EnvironmentMatcher})@unionsh
hundreds-father-404
08/29/2022, 10:32 PMWe're in sprint mode right now, and #12934 is something we want to design carefully. So I would bias towards the first solution
w
witty-crayon-22786
08/29/2022, 10:33 PMdepends which is more expedient probably… both are interface changes to how unions are declared/used… but neither is likely to affect plugin authors, since they don’t declare their own
@unions👍 1
witty-crayon-22786
08/29/2022, 11:59 PMhmmm. gotta run, but: https://github.com/pantsbuild/pants/issues/12934#issuecomment-1230987881