<@U06A03HV1> I came up with modeling for how a use...
# development
h
@witty-crayon-22786 I came up with modeling for how a user specifies what environment a target should use. https://docs.google.com/document/d/1vXRHWK7ZjAIp2BxWLwRYm1QOKDeXx02ONQWvXDloxkg/edit#heading=h.l8tbyq7h6zch
đź‘Ť 1
w
nice: will look after i’ve got something out for https://github.com/pantsbuild/pants/issues/12934
đź‘Ť 1
h
One thing I don't love is the boilerplate to define environments: 1. create a target 2. add to
[environments].aliases
But as discussed, I do think
[environments].aliases
is a non-negotiable to avoid the
AllTargets
rule graph cycle, and to allow users to override things via options system This is mitigated by allowing you to leave off environments if the default is fine for you
w
ended up commenting, because i’ll be in meetings for a bit
thanks!
h
@witty-crayon-22786 thanks for the feedback - to confirm, does the overall design look good? I think I can get started on all the subsystem logic & Target API stuff. I will wait to do the actual per-target consumption, which maybe we pair on
w
yea, looks good: thanks. i’ve added a few more comments emphasizing the difference between “matching” an environment, and the definition of an environment itself.
đź‘Ť 1
but the overall shape makes sense.