https://pantsbuild.org/ logo
h

hundreds-father-404

08/30/2022, 5:35 PM
@witty-crayon-22786 I came up with modeling for how a user specifies what environment a target should use. https://docs.google.com/document/d/1vXRHWK7ZjAIp2BxWLwRYm1QOKDeXx02ONQWvXDloxkg/edit#heading=h.l8tbyq7h6zch
👍 1
w

witty-crayon-22786

08/30/2022, 5:35 PM
nice: will look after i’ve got something out for https://github.com/pantsbuild/pants/issues/12934
👍 1
h

hundreds-father-404

08/30/2022, 5:36 PM
One thing I don't love is the boilerplate to define environments: 1. create a target 2. add to
[environments].aliases
But as discussed, I do think
[environments].aliases
is a non-negotiable to avoid the
AllTargets
rule graph cycle, and to allow users to override things via options system This is mitigated by allowing you to leave off environments if the default is fine for you
w

witty-crayon-22786

08/30/2022, 5:59 PM
ended up commenting, because i’ll be in meetings for a bit
thanks!
h

hundreds-father-404

08/30/2022, 6:29 PM
@witty-crayon-22786 thanks for the feedback - to confirm, does the overall design look good? I think I can get started on all the subsystem logic & Target API stuff. I will wait to do the actual per-target consumption, which maybe we pair on
w

witty-crayon-22786

08/30/2022, 6:37 PM
yea, looks good: thanks. i’ve added a few more comments emphasizing the difference between “matching” an environment, and the definition of an environment itself.
👍 1
but the overall shape makes sense.