How penalized will we be if I m making a `Snapshot` for my p Pants #development

How penalized will we be if I'm making a `Snapshot...

bitter-ability-32190

08/31/2022, 10:50 AM

How penalized will we be if I'm making a

Snapshot

for my plugin implementors and only some of them use the

Digest

(the other build their own from the

files

plus other info)

hundreds-father-404

08/31/2022, 1:27 PM

Penalized in what sense?

hundreds-father-404

08/31/2022, 1:27 PM

Is this for fmt/fix/lint?

bitter-ability-32190

08/31/2022, 1:28 PM

Yes it is. And penalized in the space/time dimensions

bitter-ability-32190

08/31/2022, 1:28 PM

The TL;DR is ideally there's a lowest common denominator on the requests to fmt/lint/fix tools. That happens to be a snapshot (because of the pipeline nature of fmt/fix)

hundreds-father-404

08/31/2022, 2:15 PM

I see, but

lint

does not need the snapshot. It can't be a digest? That's cheaper

bitter-ability-32190

08/31/2022, 2:16 PM

Some linters use the snapshot, others use the

files

and build their own Snapshot (from transitive targets and the like)

witty-crayon-22786

08/31/2022, 5:35 PM

it used to be a lot cheaper to hold a

Digest

, but the difference has been reduced signifificantly with the move to

DigestTrie

witty-crayon-22786

08/31/2022, 5:36 PM

they’re not equivalent, but in 95% of cases converting from a

Digest

to a

Snapshot

will not involve any io

bitter-ability-32190

08/31/2022, 5:36 PM

In this case, I'm requesting a snapshot from pathglobs. And then the user might just ignore it.

bitter-ability-32190

08/31/2022, 5:37 PM

I suspect in the end, the pros outweigh the cons. But this is the glaring mark on the implementation 😕

Open in Slack

Previous Next