Our first successful `python test` run via Docker ``` pants Pants #development

Our first successful `python_test` run via Docker!...

hundreds-father-404

09/13/2022, 9:03 PM

Our first successful

python_test

run via Docker!!

Copy code

❯ ./pants test src/python/pants/util/strutil_test.py --no-python-infer-conftests
15:59:29.45 [INFO] Completed: Building 1 requirement for requirements.pex from the 3rdparty/python/user_reqs.lock resolve: pytest<7.1.0,>=6.2.4
15:59:36.38 [INFO] Completed: Building pytest_runner.pex
15:59:38.55 [INFO] Completed: Run Pytest - src/python/pants/util/strutil_test.py:tests succeeded.

✓ src/python/pants/util/strutil_test.py:tests succeeded in 2.15s.

🎊 3

🔥 4

hundreds-father-404

09/13/2022, 9:03 PM

Apply this diff on

main

, and make sure Docker is running:

Copy code

diff --git a/src/python/pants/util/BUILD b/src/python/pants/util/BUILD
index 76d0a50a8a..eb3d2c21cf 100644
--- a/src/python/pants/util/BUILD
+++ b/src/python/pants/util/BUILD
@@ -3,4 +3,4 @@
 
 python_sources()
 
-python_tests(name="tests")
+python_tests(name="tests", _environment="docker")

hundreds-father-404

09/13/2022, 9:06 PM

@bitter-ability-32190 the

--no-python-infer-conftests

is necessary because our

conftest.py

uses

target.py

, which transitively uses

native_engine

. That is a

resource

that blindly gets copied into the Docker sandbox: it's not platform aware. So, when run on Docker from macOS, we end up with

invalid ELF header

To facilitate us working on this project, thoughts on me rewriting the

conftest.py

check for badly named Fields to instead be a Flake8 first-party plugin? Or any other suggestions?

👀 1

bitter-ability-32190

09/13/2022, 9:38 PM

I avoided flake8 because the facilities to do this are weak. If you wanna tackle it be my guest 😛 Otherwise I'm confident we could find a way to adjust conftest

👍 1

witty-crayon-22786

09/14/2022, 1:36 AM

Very exciting! Nice work @fast-nail-55400, @hundreds-father-404, @ancient-vegetable-10556.

❤️ 1

hundreds-father-404

09/14/2022, 3:33 PM

and you too with the graph changes!

Open in Slack

Previous Next