bitter-ability-32190
09/22/2022, 5:44 PMterraform fmt
is it OK if we're formatting a subset of files in a directory? E.g. if a directory has [a, b, c]
and we fmt [a, b]
in one process and [c]
in another?fast-nail-55400
09/22/2022, 5:49 PMterraform fmt
invocation is only passed the directory and not the files therein.bitter-ability-32190
09/22/2022, 5:49 PMfast-nail-55400
09/22/2022, 5:50 PM.tf
files in that directory.bitter-ability-32190
09/22/2022, 5:52 PMfast-nail-55400
09/22/2022, 5:52 PMbitter-ability-32190
09/22/2022, 5:53 PMdir/A.tf dir/B.tf dir/C.tf
It's incorrect for Pants to produce 2 processes:
1. A process with a snapshot of just dir/A.tf
, process args are dir
2. A process with a snapshot of dir/B.tf
and dir/C.tf
process args are dir
fast-nail-55400
09/22/2022, 5:53 PMgo vet
may have a similar requirement if it needs to see the whole go_package
terraform validate
. All three files constitute the Terraform module and they can have circular references to each other without need to do import symbols or anything.bitter-ability-32190
09/22/2022, 5:55 PMfast-nail-55400
09/22/2022, 5:57 PM(this is for an upcoming change, not PR 16966)ack. I misunderstood then.
bitter-ability-32190
09/22/2022, 5:57 PMlint
to "batch" the inputs because it does so by target and terraform_module
is a single target representing multiple files?fast-nail-55400
09/22/2022, 5:58 PMterraform fmt
since all it does is format files, but that would not likely work for terraform validate
which does semantic checks. And I would classify "trying get away with it" in this case to be a hack around good abstraction on how we modeled Terraform.bitter-ability-32190
09/22/2022, 8:13 PMYou could technically get away with batching by file forIn order to make progress, I think I'm going to move forward doing this, and file a ticket to collaborate on a better solution to batching/partitioning.since all it does is format files,terraform fmt
fast-nail-55400
09/25/2022, 6:01 PMterraform
models modules could end up in place for an extended period of time due to lack of developer time to make the fix.bitter-ability-32190
09/25/2022, 6:11 PM