https://pantsbuild.org/ logo
#development
Title
# development
w

wide-energy-11069

10/02/2022, 5:14 AM
can’t seem to get the CI to pass https://github.com/pantsbuild/pants/actions/runs/3171614156/jobs/5165838938:
Copy code
rule_runner = RuleRunner(build_root=/tmp/_BUILD_ROOTxosqderi)

    def test_3rdparty_plugin(rule_runner: RuleRunner) -> None:
        # Test extra_files option
        rule_runner.write_files(
            {
                "f.py": "assert 1 == 1\n",
                ".bandit": "[bandit]\nskips: B101\n",
                "BUILD": "python_sources(name='t')",
            }
        )
        tgt = rule_runner.get_target(Address("", target_name="t", relative_file_path="f.py"))
        result = run_flake8(
            rule_runner,
            [tgt],
            extra_args=[
                "--flake8-extra-requirements=flake8-bandit==3.0.0",
                "--flake8-lockfile=<none>",
                "--flake8-extra-files=['.bandit']",
            ],
        )
        assert len(result) == 1
>       assert result[0].exit_code == 0
E       assert 1 == 0
E         +1
E         -0

src/python/pants/backend/python/lint/flake8/rules_integration_test.py:213: AssertionError
- generated xml file: /tmp/pants-sandbox-I8SwJL/src.python.pants.backend.python.lint.flake8.rules_integration_test.py.tests.xml -
What would be a good approach forward, filing an issue and skipping the test?
e

enough-analyst-54434

10/03/2022, 6:59 AM
That's an internal test fix so no need to update the changelog, you just need to merge the commit to get your PR green.
w

wide-energy-11069

10/03/2022, 7:08 AM
oh cool. thanks john!
I’ll try to pick this up later this evening, as there are commits going in during the day.
w

witty-crayon-22786

10/03/2022, 7:21 PM
sorry for the trouble here!