https://pantsbuild.org/ logo
#development
Title
# development
r

refined-addition-53644

10/04/2022, 10:27 AM
Hi, I remember there were some talks/changes about speeding up mypy check done by @bitter-ability-32190 Have they already been released? If so which version?
1
b

bitter-ability-32190

10/04/2022, 10:29 AM
2.14 uses the mypy cache
👍 1
r

refined-addition-53644

10/04/2022, 10:30 AM
ah ok! Thanks! I suppose it was worse back then. I added it as pre-commit check and mypy is the slowest one among all, even with
--changed-since
b

bitter-ability-32190

10/04/2022, 11:27 AM
How long we talking?
Also this landed on some version of 2.14, so make sure you're using a layer version
r

refined-addition-53644

10/04/2022, 2:48 PM
Seems it happened only once when it took like ~1 min for handful of files (2-3 files). Now it seems to be well under ~5 secs with cache being used.
b

bitter-ability-32190

10/04/2022, 2:49 PM
That sounds about right
👍 1
mypy
is quite "smart" its caching. It actually caches a hash of the file's "interface", not the hash of the file. So conceivably adding newlines or style changes shouldn't invalidate the cache. Cool stuff!
😮 2
b

busy-vase-39202

10/04/2022, 4:56 PM
Wow. Nice.