https://pantsbuild.org/ logo
#development
Title
# development
p

polite-garden-50641

10/05/2022, 6:26 PM
seeing this error in 2.15.0 dev 3:
Copy code
Traceback (most recent call last):
  File "/home/toolchain/.cache/pants/setup/bootstrap-Linux-x86_64/2.15.0.dev3_py39/lib/python3.9/site-packages/pants/engine/internals/selectors.py", line 593, in native_engine_generator_send
    res = func.send(arg)
  File "/home/toolchain/.cache/pants/setup/bootstrap-Linux-x86_64/2.15.0.dev3_py39/lib/python3.9/site-packages/pants/backend/go/lint/gofmt/rules.py", line 48, in partition_gofmt
    else Partitions.single_partition(
  File "/home/toolchain/.cache/pants/setup/bootstrap-Linux-x86_64/2.15.0.dev3_py39/lib/python3.9/site-packages/pants/core/goals/lint.py", line 142, in single_partition
    return Partitions([(key, tuple(elements))])
  File "/home/toolchain/.cache/pants/setup/bootstrap-Linux-x86_64/2.15.0.dev3_py39/lib/python3.9/site-packages/pants/backend/go/lint/gofmt/rules.py", line 49, in <genexpr>
    field_set.sources.file_path for field_set in request.field_sets
AttributeError: 'GoPackageSourcesField' object has no attribute 'file_path'
b

bitter-ability-32190

10/05/2022, 6:28 PM
Yeah I noticed that bug earlier today 😞 Thats on me
SO the good news is I have the fix primed and ready 🙂 The bad news is it's blocked by another PR 😄
f

fast-nail-55400

10/05/2022, 6:37 PM
also it seems
src/python/pants/backend/go/lint/gofmt/rules_integration_test.py
passes. any theory as to why that test didn't fail?
b

bitter-ability-32190

10/05/2022, 6:38 PM
f

fast-nail-55400

10/05/2022, 6:39 PM
is there anything remaining to be done with https://github.com/pantsbuild/pants/pull/17103?
I can just merge it now
b

bitter-ability-32190

10/05/2022, 6:39 PM
I was waiting for Erics OK. They have good opinions on these things 🙂
h

hundreds-father-404

10/05/2022, 7:40 PM
*reminder s/he/they
b

bitter-ability-32190

10/05/2022, 7:42 PM
wow I haven't had one of those reminders ina while. But also sorry
💜 1