#development
Title
b
bitter-ability-32190
10/10/2022, 4:02 PMMaybe 🐞 on 2.14.0rc3?
Copy code
MappingError: Failed to parse ./path/to/BUILD.pants:
Name 'wo_resolved_system_packages' is not defined.
...
All registered symbols: ['__defaults__', ..., 'wo_resolved_system_packages', ...]✅ 1
So I have 2 macro files declared as:
Copy code
build_file_prelude_globs = [
# These are our Watson Orders macros (for reducing boilerplate)
"pants-plugins/wo_syspkg_macros.py",
"pants-plugins/wo_macros.py",
]wo_resolved_system_packagesBUILD.pants(Jumping from 2.13.0rc1 to 2.14.0rc3)
(And I can't easily merge the two files 🙂 One is generated 😛)
Hmm:
pants.engine.internals.build_files.parse_address_family Copy code
This also means that if multiple
# prelude files are present, they probably cannot see each others' symbols. We may choose
# to change this at some point.👍 1
👀 1
h
hundreds-father-404
10/10/2022, 5:56 PMfeel free to improve that
b
bitter-ability-32190
10/10/2022, 5:57 PMwell whats weird from looking at the code is that this worked in 2.13 and the code doesn't seem to have changed (much). Defintely not the code referenced in the comment
h
hundreds-father-404
10/10/2022, 5:58 PMI made a lot of changes to parser.py etc for the sake of environments, but I thought it was only on 2.15
b
bitter-ability-32190
10/10/2022, 5:59 PM__defaults__h
hundreds-father-404
10/10/2022, 5:59 PMah yeah, which was a big change
b
bitter-ability-32190
10/10/2022, 6:00 PMThe parsing code wasn't heavily changed though 😕
https://github.com/pantsbuild/pants/pull/15836/files
Debugging it shows that symbol is defined 🤔
😢 1