seeing those:

20:41:15.86 [WARN] DEPRECATED: Not setting `Goal.environment_migrated=True` for `Goal` `auth-token-info` is scheduled to be removed in version 2.17.0.dev0.

See <https://www.pantsbuild.org/v2.15/docs/plugin-upgrade-guide>

20:41:15.86 [WARN] DEPRECATED: Not setting `Goal.environment_migrated=True` for `Goal` `auth-token-check` is scheduled to be removed in version 2.17.0.dev0.

See <https://www.pantsbuild.org/v2.15/docs/plugin-upgrade-guide>

sorry: this is https://github.com/pantsbuild/pants/issues/17129 … @ancient-vegetable-10556 is currently working on those, and we hope to have all of them resolved before cutting

2.15.x

. if we don’t have all of them resolved by then (or don’t want that time pressure), we could do something to silence the deprecation only for the built-in/core goals, while still triggering it for plugins

Actually, those look like goals added by the toolchain plugin. I suspect they can just be resolved by marking the migration as done and moving on?

yeah the toolchain goals don't do builds so they should have no need to compute an

EnvironmentName

depends whether they 1) invoke a process, 2) look at environment variables… but possibly.

Or do we want to make them explicitly request the local environment?

As a stopgap, anyone wanna add to

ignore_warnings

? 🙂

@witty-crayon-22786 Only pants config environment variables

yea: try it and see if toggling the

Goal.environment_migrated

flag succeeds

@polite-garden-50641 see e.g. https://github.com/pantsbuild/pants/pull/17220/files#diff-96dbffb30cf9341edd3f0c92d69c7085693d46df619fff8ec40a5f09569ba362R103-R106

As a stopgap, anyone wanna add to

ignore_warnings

?

i’d feel better about skipping ahead to do:

we could do something to silence the deprecation only for the built-in/core goals, while still triggering it for plugins

…otherwise we might miss some and forget that we’re still showing the warning to users

okie doke

just want to get ahead of this. thank you all for the help, will get a version of the plugin that addresses those deprecations in the next week or so. FWIW, the toolchain plugin does use env variables (read the values of some of them) to help with CI integration (it basically reads some env variables set by the CI system)

FWIW, the toolchain plugin does use env variables (read the values of some of them) to help with CI integration (it basically reads some env variables set by the CI system)

yea… you’ll probably want to use

ChosenLocalEnvironmentName

for that, as mentioned in the doc

also in CI, the auth token value is read from an env variable. see: https://docs.toolchain.com/docs#configure-pants-to-use-remote-caching-in-your-ci-environment

OK, I can help you out with the environment variables side of things when the time comes, just ping me or Stu

@polite-garden-50641: or… hm. actually, that’s the AuthPlugin/StreamingWorkunitsPlugin … those may just continue to get an environment automatically for now?

resolved by https://github.com/pantsbuild/pants/pull/17436

thanks!