polite-garden-50641
10/13/2022, 8:42 PM20:41:15.86 [WARN] DEPRECATED: Not setting `Goal.environment_migrated=True` for `Goal` `auth-token-info` is scheduled to be removed in version 2.17.0.dev0.
See <https://www.pantsbuild.org/v2.15/docs/plugin-upgrade-guide>
20:41:15.86 [WARN] DEPRECATED: Not setting `Goal.environment_migrated=True` for `Goal` `auth-token-check` is scheduled to be removed in version 2.17.0.dev0.
See <https://www.pantsbuild.org/v2.15/docs/plugin-upgrade-guide>
polite-garden-50641
10/13/2022, 8:42 PMpolite-garden-50641
10/13/2022, 8:43 PMpolite-garden-50641
10/13/2022, 8:43 PMwitty-crayon-22786
10/13/2022, 8:50 PM2.15.x
.
if we don’t have all of them resolved by then (or don’t want that time pressure), we could do something to silence the deprecation only for the built-in/core goals, while still triggering it for pluginswitty-crayon-22786
10/13/2022, 8:51 PMancient-vegetable-10556
10/13/2022, 8:51 PMfast-nail-55400
10/13/2022, 8:52 PMEnvironmentName
witty-crayon-22786
10/13/2022, 8:52 PMancient-vegetable-10556
10/13/2022, 8:52 PMbitter-ability-32190
10/13/2022, 8:52 PMignore_warnings
? 🙂ancient-vegetable-10556
10/13/2022, 8:52 PMwitty-crayon-22786
10/13/2022, 8:52 PMGoal.environment_migrated
flag succeedsancient-vegetable-10556
10/13/2022, 8:53 PMancient-vegetable-10556
10/13/2022, 8:53 PMwitty-crayon-22786
10/13/2022, 8:55 PMAs a stopgap, anyone wanna add toi’d feel better about skipping ahead to do:?ignore_warnings
we could do something to silence the deprecation only for the built-in/core goals, while still triggering it for plugins…otherwise we might miss some and forget that we’re still showing the warning to users
bitter-ability-32190
10/13/2022, 8:55 PMpolite-garden-50641
10/13/2022, 8:56 PMwitty-crayon-22786
10/13/2022, 8:57 PMFWIW, the toolchain plugin does use env variables (read the values of some of them) to help with CI integration (it basically reads some env variables set by the CI system)yea… you’ll probably want to use
ChosenLocalEnvironmentName
for that, as mentioned in the docpolite-garden-50641
10/13/2022, 8:57 PMancient-vegetable-10556
10/13/2022, 8:57 PMwitty-crayon-22786
10/13/2022, 8:57 PMwitty-crayon-22786
10/13/2022, 8:58 PMpolite-garden-50641
11/03/2022, 5:39 PMwitty-crayon-22786
11/03/2022, 5:56 PM