Remember when we were bikeshedding a replacement f...
# development
b
Remember when we were bikeshedding a replacement for the
experimental
name and there was a brief digression about bikeshedding BUILD file name? I don't think we ever circled back to that did we?
A nuance to add to that conversation: searching slack or GH issues for issues related to BUILD files is not very helpful because "build" comes up in literally every thread regardless. A more distinctive default name for the files would make it easier for users to identify previous discussions about issues specific to problems related to BUILD files. Wouldn't be 100 accurate, but much less noise.
b
I would only want a new name so we don't squat with Bazel. My editor keeps thinking BUILD files are for Bazel. Buck uses BUCK,
please
uses BUILD.please I think. Either is fine because it doesn't squat. Users can configure the name, which I think is worthwhile to keep (and still be compatible with BUILD for posterity and for users using both tools). But I think the de-facto being something else would be ideal IMHO
w
My repos all use
BUILD.pants
, mostly because a lot of my repos use
build
for compilation and output.
If I were being cleverer, I probably would have went with
ZIPPER
or something
b
(we use BUILD.pants too)
p
I use
BUILD
simply because that is the default that tailor creates. Vim says
BUILD
files are "filetype=bzl". I've been meaning to change my vim config so it uses "filetype=python" but I haven't got around to it yet, so I often end up typing
:set ft=python
when I open a
BUILD
file.
h
I'd be happy with
BUILD.pants
as the default. If anything, makes it clear to teammates what the hell the file is for
👍 1
w
If nothing else, then just supporting the default in Pants is a start
build_patterns = ["BUILD.pants", "BUILD"]
I should note that it's also a small pet peeve of mine to have extension-less files that aren't executable.
👆 1
h
yeah, it is supported. The only thing we'd need to change is the default for
tailor
+ our docs. Not sure how to change the default for
tailor
gracefully
w
Yeah for sure, that's more of a "thing" to consider, not willy-nilly
p
We would probably need a fixer that updates tailor settings in pants.toml based on which file is present in an existing project. Tailor could even be more adaptive: when there are no
BUILD
files, add the setting to
pants.toml
to make tailor use
BUILD.pants
and then proceed to add the
BUILD.pants
files.
b
I like
BUILD.pants
too, including how it is a declarative little sentence subliminally reminding you you're using Pants now, not Bazel or whatevs.
And eventually it will make a nice visual contrast, to notice Bazel's many heavy
BUILD
files replaced by a handful of lightweight
BUILD.pants
files.