Re adding to default_module_mapping: I use `oslo.c...
# developmentp
proud-dentist-22844
10/28/2022, 5:56 PMRe adding to default_module_mapping: I use
oslo.configoslo.*h
hundreds-father-404
10/28/2022, 5:57 PMif you're down for it, I think it's useful to add them all! I used to think "we should only add if it's 100+ stars on Github", but there's little downside to having more in the mapping...Given modern machines, the extra couple bytes to store more entries seems like not a big deal
p
proud-dentist-22844
10/28/2022, 5:58 PMCool. PR forthcoming ...
proud-dentist-22844
10/28/2022, 5:59 PMseveral that I'm adding have a lot less than 100 stars 😛 oslo might (actually I don't think oslo is on Github, they self host their repos Ithink, so I guess that's moot).
proud-dentist-22844
10/28/2022, 9:43 PMWait, what? https://github.com/pantsbuild/pants/actions/runs/3347720623/jobs/5547265073#step:11:362
It says I need to use
oslo-configoslo.configoslo.configproud-dentist-22844
10/28/2022, 9:46 PMhmm. I see: https://peps.python.org/pep-0503/#normalized-names weird. ok
b
bitter-ability-32190
10/29/2022, 1:12 AMWe could also make the rules smarter (like having transformer functions for known NS packages) if it becomes hairy
p
proud-dentist-22844
10/29/2022, 6:10 AMIn this case it wasn't even a namespace package. You install
oslo.configoslo_configb
bitter-ability-32190
10/29/2022, 11:38 AMAh well if the names are well-formed a transformer function is still useful. But also potentially dangerous 🤷♂️