Discussion re batching dep inference: <https://git...
# developmenth
happy-kitchen-89482
11/06/2022, 4:47 AMDiscussion re batching dep inference: https://github.com/pantsbuild/pants/discussions/17477
b
bitter-ability-32190
11/06/2022, 11:51 AMI have a stale branch from a few months back that implements batched dependency requesting.
It's just missing the changes to Python rules to support multi-file (not hard, just didn't do it)
I'll push to my fork and send you the link tomorrow
h
happy-kitchen-89482
11/06/2022, 2:50 PMOoooh! Let’s discuss at link above?
b
bitter-ability-32190
11/06/2022, 2:52 PMYeah was gonna post link there once I push to my fork đŸ˜›
bitter-ability-32190
11/06/2022, 2:53 PMI don't have bandwidth to bring it up to date or add the python implementation.
I would recommend implementating the python rule code and measuring timings to see if it's worth bring it up to
mainh
happy-kitchen-89482
11/06/2022, 3:04 PMThat’s the thing I want to discuss on the discussion - because dep inference is inherently iterative, it’s not clear to me that batched dependency requesting is a big enough win
b
bitter-ability-32190
11/06/2022, 3:08 PMđŸ¤”
bitter-ability-32190
11/06/2022, 3:09 PMHow else would we be able to batch the inference? The core code issues a request per file
bitter-ability-32190
11/06/2022, 3:10 PM*per target
bitter-ability-32190
11/06/2022, 3:18 PMThe branch batches each iteration of traversal of depth
h
happy-kitchen-89482
11/06/2022, 3:19 PMLet’s do the discussion on the discussion? đŸ™‚