I ve stumbled across an old TODO wit

Question

< enough analyst 54434> I ve stumbled across an old TODO with your name on it wondering if I can wipe it out thread

sparse-lifeguard-95737 · Answer

TODO is here <https github com pantsbuild pants blob main src python pants backend python lint pylint rules py L166 L169>

sparse-lifeguard-95737 · Answer

it looks like the linked issue was fixed in astroid 2 9 1

sparse-lifeguard-95737 · Answer

and our default is now 2 11 7 <https github com pantsbuild pants blob main src python pants backend python lint pylint pylint lock L39 L48>

sparse-lifeguard-95737 · Answer

but I m not sure how far back in the pylint version history we want to support any thoughts

bitter-ability-32190 · Answer

In other rules we change behavior based on tool version Can you do that here

sparse-lifeguard-95737 · Answer

brain

sparse-lifeguard-95737 · Answer

is it possible to get the version of an arbitrary third party dependency vs the top level tool where we have a dedicated config for the version so we could check against astroid directly

enough-analyst-54434 · Answer

Not really without importing it

bitter-ability-32190 · Answer

Anything is possible stuck out tongue The question is how much pain you wanna feel

enough-analyst-54434 · Answer

You d need a process that used importlib

sparse-lifeguard-95737 · Answer

conceptually similar to <https github com pantsbuild pants blob main src python pants backend python goals export py L102 L119>

bitter-ability-32190 · Answer

Presumably the middle ground is looking for pylint version that contains asteroid version with the fix If people are bumping asteroid later in an earlier Pylint they ll just get a slower run than if not

enough-analyst-54434 · Answer

enough-analyst-54434 · Answer

Yeah you could also dig into PEX metadata 18 ways here

sparse-lifeguard-95737 · Answer

if we took the middle ground looks like pylint 2 13 0 is the cutoff

bitter-ability-32190 · Answer

FWIW `importlib metadata` is Python 3 8 but Pants currently runs on 3 7 Thats why I can t use it directly in `debugadapter` code You have to ask for a PEX containing the backport sob

bitter-ability-32190 · Answer

gt Yeah you could also dog into PEX metadata 18 ways here Thatd be my suggestion of the right way

bitter-ability-32190 · Answer

I d honestly +1 either solution Try the correct way by asking inspecting PEX and if that gets too hard do the middle ground with a comment

sparse-lifeguard-95737 · Answer

<https github com pantsbuild pants pull 17488> I think I figured out how to make it work the right way thinking face