sparse-lifeguard-95737
11/08/2022, 10:48 PMlint
is consistently getting OOM killed in our CI when testing out 2.15.x - is py-spy
the appropriate tool for that sort of thing? Or is there a better tool to use?witty-crayon-22786
11/08/2022, 10:58 PMpy-spy
might be good to trywitty-crayon-22786
11/08/2022, 11:00 PMsparse-lifeguard-95737
11/09/2022, 2:57 PMcore/util_rules/source_files.py:51
is ~1% of the time on 2.14, ~10% of the time on 2.15.x 🤯sparse-lifeguard-95737
11/09/2022, 2:57 PMsparse-lifeguard-95737
11/09/2022, 2:58 PMMultiGet
of HydratedSources
sparse-lifeguard-95737
11/09/2022, 2:58 PMsparse-lifeguard-95737
11/09/2022, 3:02 PMFrozenOrderedSet
everywhere, 2.15.x is using CoarsenedTargets
, probably still a ton of duplicates getting passed aroundsparse-lifeguard-95737
11/09/2022, 4:23 PMCoarsenedTargets.closure()
is yielding duplicate targets - sometimes 10s of thousands of duplicates for Color’s dependency graph - is that intended? in 2.14.x the pylint impl wrapped it in a FrozenOrderedSet
so it doesn’t look like new behavior, but it feels… wrongwitty-crayon-22786
11/09/2022, 4:53 PMclosure
should only yield unique targetswitty-crayon-22786
11/09/2022, 4:55 PMsparse-lifeguard-95737
11/09/2022, 5:04 PMsparse-lifeguard-95737
11/09/2022, 5:05 PMwitty-crayon-22786
11/09/2022, 5:10 PMwitty-crayon-22786
11/09/2022, 7:17 PMwitty-crayon-22786
11/09/2022, 7:24 PMsparse-lifeguard-95737
11/09/2022, 7:24 PMwitty-crayon-22786
11/09/2022, 7:24 PM