https://pantsbuild.org/ logo
#development
Title
# development
b

bitter-ability-32190

11/09/2022, 6:27 PM
I'm moving
<http://immutable_inputs.rs|immutable_inputs.rs>
to
store
, and I believe I've updated all references, but I get the very context-free:
Copy code
$ MODE=debug ./pants --keep-sandboxes=always fmt src/python/pants/backend/python/util_rules/pex.py
fatal: Cannot open 'src/rust/engine/process_execution/src/immutable_inputs.rs': No such file or directory
1
I've also tried
./cargo clean
Notably
process_execution/src/lib.rs
no longer has
pub mod immutable_inputs;
w

witty-crayon-22786

11/09/2022, 6:43 PM
maybe start setting
set -ex
in
pants
and the
cargo
script? it could be the scripts instead
b

bitter-ability-32190

11/09/2022, 6:44 PM
Oddly if I add the file, but empty I get:
Copy code
error: fields `store` and `contents` are never read
  --> fs/store/src/immutable_inputs.rs:21:3
   |
20 | struct Inner {
   |        ----- fields in this struct
21 |   store: Store,
   |   ^^^^^
...
26 |   contents: Mutex<HashMap<Digest, Arc<OnceCell<PathBuf>>>>,
   |   ^^^^^^^^
   |
note: the lint level is defined here
  --> fs/store/src/lib.rs:4:9
   |
4  | #![deny(warnings)]
   |         ^^^^^^^^
   = note: `#[deny(dead_code)]` implied by `#[deny(warnings)]`

error: associated function `path` is never used
  --> fs/store/src/immutable_inputs.rs:58:12
   |
58 |   async fn path(&self, directory_digest: DirectoryDigest) -> Result<PathBuf, StoreError> {
   |            ^^^^

error: associated function `local_paths` is never used
   --> fs/store/src/immutable_inputs.rs:121:23
    |
121 |   pub(crate) async fn local_paths(
    |                       ^^^^^^^^^^^
Complaining about the new location
w

witty-crayon-22786

11/09/2022, 6:45 PM
… oy.
i have generally not had issues like this with
cargo
b

bitter-ability-32190

11/09/2022, 6:45 PM
set -ex
Good call:
build-support/bin/rust/calculate_engine_hash.sh
seems ot be the culrpit
w

witty-crayon-22786

11/09/2022, 6:46 PM
would switch to iterating on
./cargo check -p engine
until you get your changes made… it’s a much faster validation (because it doesn’t actually generate code)
…and won’t do any fingerprinting, etc
b

bitter-ability-32190

11/09/2022, 6:47 PM
Yeah so looks like
build-support/bin/rust/calculate_engine_hash.sh
might not be delete-friendly
w

witty-crayon-22786

11/09/2022, 6:47 PM
having said that, i’ve never actually seen the fingerprinting fail… maybe because i’m not iterating on
./pants
when making those kinds of changes.
b

bitter-ability-32190

11/09/2022, 6:50 PM
Ah so staging the deletion fixes the above 🙄
on to the compilation issue
pub(crate)
did it 😛