Can someone with better Rust skills than my virtually nonexi

Question

Can someone with better Rust skills than my virtually nonexistent ones verify my understanding that ExternalTool downloads will respect the global `ca certs path` AFAICT those downloads end up delegated to the `http client` we construct in <http context rs|context rs> but if someone could check my work

happy-kitchen-89482 · Answer

Context is <https pantsbuild slack com archives C046T6T9U p1668108764354319>

happy-kitchen-89482 · Answer

Just the last part of that thread

witty-crayon-22786 · Answer

it should yes created here <https github com pantsbuild pants blob 952235a048e8af742367867b5b7ca21243d020b6 src rust engine src context rs L558 L565>

witty-crayon-22786 · Answer

then used here <https github com pantsbuild pants blob 952235a048e8af742367867b5b7ca21243d020b6 src rust engine src downloads rs L49 L79>

witty-crayon-22786 · Answer

i have no reason to suspect that `iter fold ` although it s probably unnecessarily obtuse

happy-kitchen-89482 · Answer

Yeah I know that http client is good for other uses just wanted to verify my understanding that it is in fact being used for ExternalTool downloads

witty-crayon-22786 · Answer

it is

witty-crayon-22786 · Answer

assuming that it is using the DownloadFile intrinsic which is the only supported way to download something

witty-crayon-22786 · Answer

seems like it <https github com pantsbuild pants blob 2a4391d326d2b48442829ff452d54d3aa6e6e86a src python pants core util rules external tool py L341 L342>

happy-kitchen-89482 · Answer

Yep