<@U021C96KUGJ>: re: `experimental_shell_command`
# developmentw
witty-crayon-22786
11/15/2022, 9:40 PM@ancient-vegetable-10556: re:
experimental_shell_commandwitty-crayon-22786
11/15/2022, 9:41 PMthe thing that is actually using immutable inputs in your repro is
experimental_run_shell_commandwitty-crayon-22786
11/15/2022, 9:41 PMand it will use them in all three runs, afaik
a
ancient-vegetable-10556
11/15/2022, 9:41 PMThere’s nothing immutable to input until the first run
w
witty-crayon-22786
11/15/2022, 9:41 PMright. so during the first run, you will pay the cost to create the immutable input. but the second run should be able to just use it
a
ancient-vegetable-10556
11/15/2022, 9:42 PMOK, so it’s probably only deciding to make an input immutable when it gets retrieved from the cache
ancient-vegetable-10556
11/15/2022, 9:43 PMwhich is what my understanding of the behaviour was until just now
w
witty-crayon-22786
11/15/2022, 9:43 PMthat shouldn’t be the case
witty-crayon-22786
11/15/2022, 9:43 PMwhich is why it’s slightly odd.
b
bitter-ability-32190
11/15/2022, 9:43 PMWait my understanding aligns with Chriss?
w
witty-crayon-22786
11/15/2022, 9:43 PMi’m suspecting some noise from a background process perhaps
b
bitter-ability-32190
11/15/2022, 9:43 PMWe don't make the immut input until it's needed as an input
a
ancient-vegetable-10556
11/15/2022, 9:44 PMStu — rightly — points out that it is an input
w
witty-crayon-22786
11/15/2022, 9:44 PMright: but each of the three runs involves two processes: an
experimental_shell_commandexperimental_run_shell_commandb
bitter-ability-32190
11/15/2022, 9:44 PMAh, I'm missing some context. Somewhat ignore me
a
ancient-vegetable-10556
11/15/2022, 9:44 PM@witty-crayon-22786 Give me a moment, I can test to see if it’s a timing issue
ancient-vegetable-10556
11/15/2022, 9:44 PMwill be a few minutes while I investigate
b
bitter-ability-32190
11/15/2022, 9:46 PMSo yeah run 2 and 3 should have the run process sped up and the non-run be memoized
w
witty-crayon-22786
11/15/2022, 9:46 PMright
b
bitter-ability-32190
11/15/2022, 9:51 PMGood chance there's bugs. I still wanna write tests for this.
a
ancient-vegetable-10556
11/15/2022, 9:52 PMOK, I now have a graph that looks like this:
Copy code
A -> B
A -> C
B -> C
A = `yarn install --immutable`
B = `sleep 5`
C = `ls {chroot}/`ancient-vegetable-10556
11/15/2022, 9:52 PM• The first run does indeed have symlinks in the output. Good!
• There’s still the three-step speedup that we saw without the indirection.
w
witty-crayon-22786
11/15/2022, 9:55 PMwould need to look at traces and/or profiles i think. my guess is a background process of some sort
witty-crayon-22786
11/15/2022, 9:55 PMbut in any case: immutable inputs are working there
witty-crayon-22786
11/15/2022, 9:55 PMthanks for confirming!
👍 1
b
bitter-ability-32190
11/16/2022, 3:31 PMNew comit will be coming in very soon with dirsize caching.
bitter-ability-32190
11/16/2022, 4:45 PMvery soon => soonish (writing tests so I feel better about it)
bitter-ability-32190
11/16/2022, 5:49 PMOK added tests 🙂