https://pantsbuild.org/ logo
Join Slack
Powered by
<@U06A03HV1> and <@U021C96KUGJ> Should we just pun...
# development
b
@witty-crayon-22786 and @ancient-vegetable-10556 Should we just punt on directories in https://github.com/pantsbuild/pants/pull/17520? While we figure out the cruft, we can start removing 
immutable_input_digests
, I think
Or do as Stu suggested and just set it to somethign redicuously high
a
annoyingly, I am only interested in this ticket because of directories, and 
immutable_input_digests
is the solution if directories aren’t solvable.
b
Well I'd hate to rush things, or halt incremental progress, for a specific use-case
a
If you’ve got valuable use case for just files, then sure
I just don’t have a horse in that race
b
System libraries 🙂
w
yes, i think punting to a followup PR makes sense. not because i don’t think that we should do it, but just so that it doesn’t hold up the clearly less troublesome aspect.
💯 2
Or do as Stu suggested and just set it to somethign redicuously high
or this, yea.
b
I guess I worry that if we set it to some high number, we just feel good and move on. Instead of fixing the roots of the issue
Well, lol the native engine is larger than our file limit 🤦‍♂️
a
I’m shocked 😉
b
I think removing dirs is still good. But damn the issue still haunts us. Pants'-dogfooding is full of surprises
In this case, I think I'll just re-materialize the file not as a symlink in the test.
Perhaps we could've done that for dirs, but meh
w
I guess I worry that if we set it to some high number, we just feel good and move on. Instead of fixing the roots of the issue
as long as it actually triggers for 
node_modules
, we can revisit… this is a heuristic
but believe me: Chris will want to pursue getting it working soon if it doesn’t
🙃 1
b
Any thought on the path huerstic for excludelisting?
Again, my long-term worry for the dirs is we really shouldn't be symlinking true source trees, as that will likely not get re-used. So it's worse for people
w
i would be fine with a (configurable?) list of pathnames as heuristic
b
@ancient-vegetable-10556 for your 
node_modules
case, are those materialized under a source root?
Well, at any rate https://github.com/pantsbuild/pants/pull/17520 now just does files. I'm hoping for green CI.
https://github.com/thejcannon/pants/tree/bigfile-and-dirs is a branch made from the OG before I removed dirs. So we can use that to bring back directories
👍 1
Open in Slack
PreviousNext
Powered by