https://pantsbuild.org/ logo
Join Slack
Powered by
<@U02KAN6061E> ```All `__init__.py` file should be...
# development
c
@bitter-ability-32190
Copy code
All `__init__.py` file should be empty, but the following had content: src/python/pants/__init__.py
??
✅ 1
I guess that one should be an exception?
b
Where do you see this?
c
from running pre-commit hook… i.e. build-support/bin/check_inits.py
b
oh womp womp
c
I have a change under way
so could put that in there..
b
Yes that should be excluded from the check
c
was just curious you hadn’t seen this already 😛
was a few other small nits in that script to adjust as well…
b
I dont run that script 🙈
c
oohh… not using the pants pre-commit hook, then? 😮 🙉
h
I thought we weren’t doing that?
c
well, it’s in the pre-commit hook-- err, did you mean not using the pre-commit hook?
h
I meant not putting code in 
__init__.py
, but then realized that this is the top-level namespace package one, so of course it has to contain the namespace package incantation
c
ah, yes, hence the exception 🙂
h
Yep, working as intended!
👍 1
b
Why is this in the commit hook but not CI? Seems like a recipe for... well this thread 🙂
🤪 1
h
It should be in CI and not the commit hook if you ask me 🙂
b
Agreed
c
why not both?
b
Well if was in pants it would be in both 😳
Open in Slack
PreviousNext
Powered by