I have so many open PRs, so I’m reluctant to even ...
# developmentc
curved-television-6568
11/27/2022, 5:10 PMI have so many open PRs, so I’m reluctant to even assign reviewers to them at this point as I don’t know how to distribute the “load”.. so, if you feel like doing a bit of reviewing, pls pick any open ones of these: https://github.com/pantsbuild/pants/pulls?q=is%3Aopen+is%3Apr+author%3Akaos+no%3Aassignee+review%3Arequired+draft%3Afalse 😛 🙏
f
fast-nail-55400
11/27/2022, 5:11 PMHow many of these need "design" review?
fast-nail-55400
11/27/2022, 5:12 PMAnd by "design" I mean the user experience, not the technical implementation.
fast-nail-55400
11/27/2022, 5:14 PMfor example. https://github.com/pantsbuild/pants/pull/17652 is for
envfast-nail-55400
11/27/2022, 5:14 PMI'm less inclined personally to do design review type PRs without some broader input into them from other maintainers.
c
curved-television-6568
11/27/2022, 5:15 PMgood point, those with “new feature” would be nice to get some design review on
curved-television-6568
11/27/2022, 5:16 PMI can go and try review some of the latter types of PRs.thanks! that would be the two labeled as bugfix, I suppose 🙂
f
fast-nail-55400
11/27/2022, 5:17 PMhttps://github.com/pantsbuild/pants/pull/15198 is still marked draft. I assume that should not be reviewed?
fast-nail-55400
11/27/2022, 5:18 PMah you updated the link to exclude draft
👍 1
c
curved-television-6568
11/27/2022, 10:51 PMThanks for those reviews @fast-nail-55400 ❤️
w
witty-crayon-22786
11/29/2022, 9:14 PMsorry for the delays!
🙏 1
witty-crayon-22786
11/29/2022, 9:14 PMrelatedly: i’m about to declare bankruptcy on my github email notifications, and go with only https://github.com/pulls/review-requested until i’m caught up… so please do mark me reviewer if i can help with something
👍 2
p
polite-garden-50641
11/29/2022, 9:29 PMhttps://github.com/pantsbuild/pants/pull/17628
I don't have permissions to assign reviewers.