I m hitting an issue with DictOption `fromfile` pointing to

Question

I m hitting an issue with DictOption `fromfile` pointing to a YAML file where a newline at the end makes a difference but the parsing code uses ` strip ` on the file contents I think thats a bug

curved-television-6568 · Answer

what difference does the newline do

bitter-ability-32190 · Answer

It depends on the plugin no

bitter-ability-32190 · Answer

In this case the copyright header being stamped is eating the first line slightly smiling face

curved-television-6568 · Answer

oh eyes

curved-television-6568 · Answer

in my experience so is relying on whitespace in files especially at the end a source of headaches

bitter-ability-32190 · Answer

Shouldn t the underlying parsing libraries handle that though

bitter-ability-32190 · Answer

`json loads ` and `yaml safe load`

curved-television-6568 · Answer

oh they do I mean that from a users perspective so can the absence or presence of a final newline trip them up if that s significant

bitter-ability-32190 · Answer

YAML is a god awful spec but better than handcrafting JSON

curved-television-6568 · Answer

agree

bitter-ability-32190 · Answer

OK I m gonna PR this

bitter-ability-32190 · Answer

curved-television-6568 · Answer

I see so in this case we tripped the user up with no sensible out stuck out tongue

happy-kitchen-89482 · Answer

Yeah that is a bug

happy-kitchen-89482 · Answer

We should not strip if the newline is significant

happy-kitchen-89482 · Answer

I ll bet I was the one that introduced that strip unnecessarily