https://pantsbuild.org/ logo
b

bitter-ability-32190

12/04/2022, 3:18 PM
@witty-crayon-22786 how would you feel about us making the archive+immutable "fix" a "known bug" for the time being? (With the intent of fixing it still in 2.16)
I'm feeling a bit burnt out on the PR and would love to remove the current immutable stuff as a way to make the code cleaner And I think that'll help clear up my mental fog as well
w

witty-crayon-22786

12/05/2022, 6:23 PM
sure, fine with me.
thanks again for tackling that.
b

bitter-ability-32190

12/05/2022, 6:23 PM
This is now moot if we use hardlinks, which I switched the PR to 😄
w

witty-crayon-22786

12/05/2022, 6:29 PM
it isn’t… the file permissions would still get captured by
tar
, right?
but still fine punting on it.
b

bitter-ability-32190

12/05/2022, 6:30 PM
That would've been an issue regardless 😅
w

witty-crayon-22786

12/05/2022, 6:32 PM
files have in the past always been materialized as writeable (since reapi can’t actually capture the r/w bit anyway), so it’s a change. but not as important a change as the symlink would be
b

bitter-ability-32190

12/05/2022, 6:34 PM
agreed