https://pantsbuild.org/ logo
#development
Title
# development
b

bitter-ability-32190

12/10/2022, 2:51 AM
@sparse-lifeguard-95737 I think we left some cruft in
test
between the old union
TestFieldSet
and the new union
TestRequest
. ā€¢ Is
TestFieldSet
supposed to be a union? ā€¢ Should the
TestSubsystem
be asking if
TestRequest
is in
union_membership
instead of
TestFieldSet
?
Or was that left for backwards compat?
s

sparse-lifeguard-95737

12/10/2022, 2:54 AM
I am not sure for either šŸ˜… I set a reminder for myself to investigate Monday morning
b

bitter-ability-32190

12/10/2022, 2:54 AM
šŸ™
OK just removed it and eveyrhting still works
s

sparse-lifeguard-95737

12/12/2022, 1:44 PM
looks like Iā€™m late to the party šŸ˜… thanks for cleaning it up @bitter-ability-32190!
b

bitter-ability-32190

12/12/2022, 3:33 PM
I was already in the neighborhood. Looks like the union IS necessary, but shifting the registration into
.rules()
makes it behind-the-scenes