https://pantsbuild.org/ logo
#development
Title
# development
b

busy-vase-39202

01/09/2023, 1:57 PM
Is GHA being extra slow today? And/or has the workflow for docs changes recently been modified? Re-running CI on a single-line doc change took 16:25 minutes just now. https://github.com/pantsbuild/pants/actions/runs/3874331854
h

happy-kitchen-89482

01/09/2023, 2:07 PM
Huh. A docs-only change should skip all the CI jobs!
The "classify changes" job claimed that this PR affected everything!
Oh, I see the issue. I think you hadn't pulled main recently?
It's seeing a ton of changed files that you didn't actually change
So something is wrong with the merge base as detected by the
tj-actions/changed-files@v32
action I guess
b

busy-vase-39202

01/09/2023, 2:13 PM
Wrong at my end, or at GHA's end?
❯ git pull pantsbuild main
remote: Enumerating objects: 159, done. remote: Counting objects: 100% (145/145), done. remote: Compressing objects: 100% (87/87), done. remote: Total 159 (delta 61), reused 108 (delta 48), pack-reused 14 Receiving objects: 100% (159/159), 148.98 KiB | 2.10 MiB/s, done. Resolving deltas: 100% (61/61), completed with 21 local objects. From github.com:pantsbuild/pants * branch main -> FETCH_HEAD d098b5843..c676ef922 main -> pantsbuild/main Successfully rebased and updated refs/heads/team. ❯ git push cczona team To github.com:cczona/pants.git ! [rejected] team -> team (non-fast-forward) error: failed to push some refs to 'github.com:cczona/pants.git' hint: Updates were rejected because the tip of your current branch is behind hint: its remote counterpart. Integrate the remote changes (e.g. hint: 'git pull ...') before pushing again. hint: See the 'Note about fast-forwards' in 'git push --help' for details.
Ah. Solved with
git pull cczona team
. I think it must have gotten ahead of local when I used github's "sync branch" button last week. Lesson learned. Stick to the cli.
1
At least now the PR sees those unrelated 14 commits, consistent with what GHA detected. Do I need to redo the PR to avoid causing messiness for the cherry-pick?
h

happy-kitchen-89482

01/09/2023, 2:25 PM
Yeah, merge main into your branch, and then push it
b

busy-vase-39202

01/09/2023, 2:25 PM
I did, that's how the extra commits showed up in the PR. Is that okay?
Correction, I did
git pull
main into my branch. Do you mean literally do
git merge
?
Ah-hah, yes, now CI run is back to seconds and skipping most checks. Thanks!