bitter-ability-32190
02/03/2023, 6:55 PMscie-pants
and what it implies, but I don't think we need to rush it, per-se. It's new, and likely experimental
-by-another-name, so thorns may exist.
My 2cenough-analyst-54434
02/03/2023, 7:01 PMbitter-ability-32190
02/03/2023, 7:01 PMwitty-crayon-22786
02/03/2023, 7:06 PMscie-pants
, per-se… we also see those errors in CI.curved-television-6568
02/03/2023, 7:13 PMscie-pants
in the wild for quite some time..wide-midnight-78598
02/03/2023, 7:39 PMpants eject
-> creates ./pants
script in repo (with probably a punnier, non-create-react-app name (takeoff, strip, disrobe, etc)
My 1.34 cents (man, CAD to USD conversion is a killer) would be that any useful "not rushed" solution basically comes down to our documentation and how promotional the scie-pants approach is. e.g. In the installation, in lieu of replacing the existing ./pants
script solution, that still stays front and centre, while below it we show off the "cool, new awesome, xtreme `scie-pants`" route.
Leave it to new users to decide. But I think the practical and pragmatic reality is that the existing user base will stick with the bootstrap script, and if they switch over - pain points might rear their head after any expected amount of testing.
The one surprise to me was around in-repo plugins workflow, where I think we still need a system python 3.9 interpreter? That's all fine, I just didn't see it in the new docs.happy-kitchen-89482
02/03/2023, 7:51 PM./pants
if they have to, and new users are about as likely to encounter issues with scie-pants as with ./pants
(judging by the amount of support we've had to do over Pants finding the wrong/no interpreter)curved-television-6568
02/03/2023, 7:54 PMhappy-kitchen-89482
02/03/2023, 7:54 PMcurved-television-6568
02/03/2023, 7:56 PMenough-analyst-54434
02/03/2023, 7:58 PMThe one surprise to me was around in-repo plugins workflow, where I think we still need a system python 3.9 interpreter? That's all fine, I just didn't see it in the new docs.You need a system interpreter to run Pants on python code. That is true whether the code is plugin code or business code or whatever. If you don't want to lint and test your plugin code with Pants, you absolutely do not need a system Python interpreter - the in-repo plugin code will run just fine. This is no different than today and is actually only required to guards against in-repo plugin code with platform-specific dependencies only distributed as sdists. A pretty narrow class I'd think. I took the PBS off PATH for this reason alone. I could add the option to add it back of course.
wide-midnight-78598
02/03/2023, 8:01 PMenough-analyst-54434
02/03/2023, 8:02 PM./pants
to pants
and nuke other configuration to bust your already working in-repo plugins.wide-midnight-78598
02/03/2023, 8:04 PMenough-analyst-54434
02/03/2023, 8:06 PMwide-midnight-78598
02/03/2023, 8:10 PMenough-analyst-54434
02/03/2023, 8:12 PMproud-dentist-22844
02/03/2023, 8:13 PMenough-analyst-54434
02/03/2023, 8:14 PMproud-dentist-22844
02/03/2023, 8:16 PMenough-analyst-54434
02/03/2023, 8:17 PM__file__
though which presented @ancient-vegetable-10556 plenty of pain.proud-dentist-22844
02/03/2023, 8:18 PM__file__
.enough-analyst-54434
02/03/2023, 8:19 PMproud-dentist-22844
02/03/2023, 8:21 PM__file__
is a cheap way to get the full path to a script and record an inferrable dependency at the same time. So, I'm glad this will continue to work: https://github.com/StackStorm/st2/blob/master/pants-plugins/uses_services/mongo_rules.py#L40bitter-ability-32190
02/03/2023, 8:23 PM__file__
)proud-dentist-22844
02/03/2023, 8:23 PMpants drop
(instead of "eject")ancient-vegetable-10556
02/03/2023, 8:23 PMpantsup
is not a thing any more ;))enough-analyst-54434
02/03/2023, 8:35 PM(in-repo Plugins would've always hadNot if the Python embeds Rust -> Rust embeds Python ticket had been resolved with PyOxy. Handling)__file__
__file__
was already a bear for Pants itself in the work Chris did there. I don't believe there was a solution for in-repo plugins. I may be wrong there though.ancient-vegetable-10556
02/03/2023, 8:36 PMenough-analyst-54434
02/03/2023, 8:36 PMancient-vegetable-10556
02/03/2023, 8:37 PM