I'm merging <https://github.com/pantsbuild/pants/p...
# development
I'm merging https://github.com/pantsbuild/pants/pull/18054 (I'm assuming just hitting the big green squash-and-merge button is all that I need to do once I have approvals, there's no bors-like merge queue or other processes), and noticed that the commit message was the default squash-and-merge message of concatenating the individual commit messages. The convention suggested by "FYI: we squash merge" in https://www.pantsbuild.org/docs/contributor-overview#opening-a-pull-request seems to be using the PR description. Relatively recently, Github added support for defaulting to that style ("PR title + description"): https://github.blog/changelog/2022-08-23-new-options-for-controlling-the-default-commit-message-when-merging-a-pull-request/ We've found this setting a nice little time saver (and mistake reducer) in our repo.
I've set this up for Pex, scie-pants and the a-scie projects. I have not bothered to bring it up re the Pants repo just because I have trouble gauging controversy. +1 to doing this from me!
👍 4
I'm bright-eyed, idealistic and missing historical context for any hot-button issues. Hopefully I'm not bringing up a sore point for anyone... I apologise if so.
I don't think you are but I guess wrong too often myself; so I shy away.
Nice feature! I'll make this change when I'm in front of a normal sized computer. I don't think it requires debate.
🎉 2
Oh thank goodness 🎉🎉🎉🎉