we don’t require reviews on cherry-picks. is that ...
# developmentc
curved-television-6568
03/09/2023, 3:58 PMwe don’t require reviews on cherry-picks. is that intentional?
h
happy-kitchen-89482
03/09/2023, 4:13 PMWe usually should?
happy-kitchen-89482
03/09/2023, 4:13 PMAre we not enforcing that on release branches?
c
curved-television-6568
03/09/2023, 4:49 PMh
happy-kitchen-89482
03/09/2023, 4:53 PMAha
happy-kitchen-89482
03/09/2023, 4:53 PMso, we should be...
happy-kitchen-89482
03/09/2023, 4:53 PMLemme look at that
c
curved-television-6568
03/09/2023, 5:23 PMI think there might be a reason for it… like if you’re supposed to be able to push directly to a release branch..? and this change limits that..?
curved-television-6568
03/09/2023, 5:24 PM(just ocured to me..)
w
witty-crayon-22786
03/09/2023, 5:45 PMyea, that’s why. we only actually require checks on
mainwitty-crayon-22786
03/09/2023, 5:45 PMadjusting the process to not require direct pushes would let us enable checks.
h
happy-kitchen-89482
03/09/2023, 6:00 PMAh, right
w
witty-crayon-22786
03/09/2023, 6:05 PMif we started using a PR-based cherry-pick for the version bump and notes, we wouldn’t need to directly push any more. but would mean an extra CI cycle i think
2 Views