https://pantsbuild.org/ logo
#development
Title
# development
c

curved-television-6568

03/09/2023, 3:58 PM
we don’t require reviews on cherry-picks. is that intentional?
h

happy-kitchen-89482

03/09/2023, 4:13 PM
We usually should?
Are we not enforcing that on release branches?
c

curved-television-6568

03/09/2023, 4:49 PM
h

happy-kitchen-89482

03/09/2023, 4:53 PM
Aha
so, we should be...
Lemme look at that
c

curved-television-6568

03/09/2023, 5:23 PM
I think there might be a reason for it… like if you’re supposed to be able to push directly to a release branch..? and this change limits that..?
(just ocured to me..)
w

witty-crayon-22786

03/09/2023, 5:45 PM
yea, that’s why. we only actually require checks on
main
, because of how we directly push to release branches currently.
adjusting the process to not require direct pushes would let us enable checks.
h

happy-kitchen-89482

03/09/2023, 6:00 PM
Ah, right
w

witty-crayon-22786

03/09/2023, 6:05 PM
if we started using a PR-based cherry-pick for the version bump and notes, we wouldn’t need to directly push any more. but would mean an extra CI cycle i think
2 Views