My PR is failing CI about formatting an unrelated ...
# developmentb
bitter-ability-32190
03/09/2023, 6:36 PMMy PR is failing CI about formatting an unrelated file 🤯
https://github.com/pantsbuild/pants/pull/18433
w
witty-crayon-22786
03/09/2023, 9:14 PM…maybe due to https://github.com/pantsbuild/pants/pull/18431#event-8710734212 …? but i’m not sure how.
witty-crayon-22786
03/09/2023, 9:15 PM(mine too, btw.)
witty-crayon-22786
03/09/2023, 9:26 PMahh. probably a collision between @happy-kitchen-89482’s PR and https://github.com/pantsbuild/pants/pull/17480
witty-crayon-22786
03/09/2023, 9:28 PMb
bitter-ability-32190
03/09/2023, 10:09 PMI think this is something a merge queue would've caught. Is that something we should look into. @busy-vase-39202 is there space on Mondays agenda?
b
busy-vase-39202
03/09/2023, 10:50 PMYeah. But please discuss on slack first. If it can be resolved here, fab.
b
bitter-ability-32190
03/09/2023, 10:53 PMOne thing to note is I think we couldn't have flaky tests, or else PRs might now get merged
bitter-ability-32190
03/09/2023, 10:54 PMI don't know what happens on merge queue CI failure, other than the PR not being merged
w
witty-crayon-22786
03/09/2023, 11:06 PMbased on my last read, it’s pretty configurable. but yea, someone would need to babysit a trial run, and explain it to people.
witty-crayon-22786
03/09/2023, 11:06 PMwe have collision issues roughly… twice a year though. so not sure whether it’s strictly necessary if it doesn’t have other benefits.
h
happy-kitchen-89482
03/10/2023, 12:59 AMTrue. That said, any effort to de-flake our tests would pay off in spades regardless of whether we then added a merge queue. So that step at least is important.
2 Views