https://pantsbuild.org/ logo
#general
Title
# general
h

hundreds-father-404

01/10/2019, 2:18 AM
Hey Twitter folks, how would I go about getting Pants to use the newest master version of twitter commons? Kris helped me to merge a PR that fixes a deprecation warning (https://github.com/twitter/commons/commit/ba6453e26fcb6560406f366d0c8012ab2e1cf24f), and now I’m trying to figure out how to get this into Pants Does someone need to do a release to PyPi?
a

aloof-angle-91616

01/10/2019, 2:19 AM
that sounds right, i don’t think we consume development versions of that, but not familiar with more context than you are lol
h

hundreds-father-404

01/10/2019, 2:20 AM
We have the file
3rdparty/python/twitter/commons/requirements.txt
with contents
Copy code
twitter.common.collections>=0.3.1,<0.4
twitter.common.confluence>=0.3.1,<0.4
twitter.common.dirutil>=0.3.1,<0.4
I’m not quite sure where those version numbers are coming from
a

aloof-angle-91616

01/10/2019, 2:21 AM
that’s a good point
it may be py3 support for the <0.4? i should look things up before messaging
h

hundreds-father-404

01/10/2019, 2:22 AM
Looks like version hasn’t been bumped since 2016
w

witty-crayon-22786

01/10/2019, 7:27 PM
this is lightly forked from our internal version... sigh.
but yea, it would be good to make sure we're still able to publish there.
i'll take a look this afternoon
❤️ 3
oooor the following week, i guess?
will try consuming it.
3 Views