https://pantsbuild.org/ logo
#general
Title
# general
a

average-vr-56795

02/01/2019, 4:28 PM
@witty-crayon-22786 I found out why the git hacks were in place in the pre-commit scripts! It turns out in pre-commit hooks
GIT_DIR=.git
is set which breaks git commands after you
cd
. Just un-setting
GIT_DIR
seems to fix everything… Will send out a PR…
👌 1
w

witty-crayon-22786

02/01/2019, 10:34 PM
how does this exhibit?
(...will look at PRs)
maybe like: https://travis-ci.org/pantsbuild/pants/jobs/487621959 :
Copy code
[=== 00:00 Running pre-commit checks ===]
* Checking packages
* Checking headers
* Checking for banned imports
fatal: ambiguous argument 'master': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
* Checking for bad shell patterns
The command "./build-support/bin/travis-ci.sh -fmrt" exited with 1.
?
@average-vr-56795: ^
a

average-vr-56795

02/04/2019, 7:40 PM
I have no reason to think I fixed that but it's possible... My PR merged
#7210
w

witty-crayon-22786

02/04/2019, 7:47 PM
ok, thanks. i might guess-and-check that into the release branch.
a

average-vr-56795

02/04/2019, 7:47 PM
So maybe try rebasing... But the failure I saw was about "fatal: Not a git repository" from git
w

witty-crayon-22786

02/04/2019, 7:49 PM
ok, thanks