https://pantsbuild.org/ logo
f

fancy-motherboard-24956

09/27/2019, 11:41 AM
The PR to add initial Black support to pants (as a v2 rule) is up. Getting there 😄 https://github.com/pantsbuild/pants/pull/8350
❤️ 1
a

average-vr-56795

09/27/2019, 1:20 PM
@fancy-motherboard-24956 I merged one of your PRs which I think gives you a merge conflict in this one
👍 1
f

fancy-motherboard-24956

09/27/2019, 1:27 PM
Thanks for the heads up 🙂 I’ll rebase
Done 🙂
uhm. will push again because the isort check wasn’t right the way I resolved the conflict
Done 🙂
a

average-vr-56795

09/27/2019, 1:41 PM
Have a bunch of comments, mostly around minor naming or TODOs to put in, but also, tests 😄
➕ 1
f

fancy-motherboard-24956

09/27/2019, 2:50 PM
hack week 😏
Thanks for the review 🙂
h

happy-kitchen-89482

09/27/2019, 5:43 PM
v2 rules ftw
😀 1
3 Views