But it just seems to be ignored, is there anything...
# generall
little-salesmen-78240
11/08/2019, 1:36 PMBut it just seems to be ignored, is there anything else to setup to make it work?
h
hundreds-father-404
11/08/2019, 2:01 PMWhat's the full command you're running?
l
little-salesmen-78240
11/08/2019, 2:07 PM./pants --test-junit-test-shard=1/3 --cache-test-junit-ignore test targetpath/::
h
hundreds-father-404
11/08/2019, 2:07 PMThat looks right. What happens if you do
./pants --test-junit-test-shard=0/20 test targetpath/::l
little-salesmen-78240
11/08/2019, 2:09 PMsame, in the end it executes all 249 tests
little-salesmen-78240
11/08/2019, 2:09 PMOK (249 tests)
h
hundreds-father-404
11/08/2019, 2:09 PMDo you have this option set anywhere in
pants.inil
little-salesmen-78240
11/08/2019, 2:10 PMit is not set in pants.ini
little-salesmen-78240
11/08/2019, 2:10 PMthe relevant section in pants.ini:
👍 1
little-salesmen-78240
11/08/2019, 2:11 PMUntitled
h
hundreds-father-404
11/08/2019, 2:24 PMWhat Pants version?
I do not reproduce. In the Pants repo,
./pants test tests/java/org/pantsbuild/testing::./pants test --test-junit-test-shard=0/3 tests/java/org/pantsbuild/testing::l
little-salesmen-78240
11/08/2019, 2:25 PMpants_version: 1.20.0
little-salesmen-78240
11/08/2019, 2:26 PMthe tests are actually scala tests
little-salesmen-78240
11/08/2019, 2:26 PMI don't know if that changes smth
h
hundreds-father-404
11/08/2019, 2:26 PMAh, let me see if I can reproduce that
hundreds-father-404
11/08/2019, 2:26 PMIn your BUILD, are they marked as
junit_testsl
little-salesmen-78240
11/08/2019, 2:26 PMyes
👍 1
h
hundreds-father-404
11/08/2019, 2:29 PMI do reproduce this option not working for Scala targets. Hm. I'll investigate
l
little-salesmen-78240
11/08/2019, 2:29 PMthanks very much for the help!
👖 1
little-salesmen-78240
11/08/2019, 2:29 PM🙂
h
hundreds-father-404
11/08/2019, 2:29 PMHow did you write your scala tests? Using
Scalatestl
little-salesmen-78240
11/08/2019, 2:30 PMyes
👍 1
little-salesmen-78240
11/08/2019, 2:31 PMshould i open an issue?
h
hundreds-father-404
11/08/2019, 2:33 PMWould you mind, please? We also have a contributor from Foursquare (big Scala user) who may be interested in working on this issue 🙂
For reproducing within Pants, this is what I ran:
Copy code
./pants test tests/scala/org/pantsbuild/zinc/analysis::
./pants test --test-junit-test-shard=0/4 tests/scala/org/pantsbuild/zinc/analysis::l
little-salesmen-78240
11/08/2019, 3:28 PMAlright! Thank you for the help
❤️ 1
little-salesmen-78240
11/08/2019, 3:42 PMjust created: https://github.com/pantsbuild/pants/issues/8594
👍 1
6 Views