aloof-angle-9161611/09/2019, 2:25 AM
classes. i'd really like to merge this sooner rather than later so i will probably merge before Sunday if nobody has time to review. this is a first attempt at solving this problem, it's scoped to a single subsystem so we can deprecate this approach en masse if it turns out to be wrong at first -- which is why i'm leaning towards trying to merge it earlier, so i can get feedback from users on whether it's working. this would be a massive win for many pants users at twitter who try to develop on a train or plane, and i suspect it will be similarly useful for other organizations using pants.
hundreds-father-40411/09/2019, 2:28 AM
i’d really like to merge this sooner rather than later so i will probably merge before Sunday if nobody has time to review.
aloof-angle-9161611/09/2019, 2:29 AM
hundreds-father-40411/09/2019, 2:32 AM
what is the alternative?Pinging reviewers to ask them to review, which often means things like DMing over Slack if they’re free to review during the week. But fundamentally we never should merge without review. It’s too dangerous of a precedent, even for simple PRs
aloof-angle-9161611/09/2019, 2:32 AM
happy-kitchen-8948211/09/2019, 4:06 AM