https://pantsbuild.org/ logo
h

hundreds-breakfast-49010

12/06/2019, 2:00 AM
would anyone object if I combined the separate
write_stdout
and
print_stdout
methods on
Console
(and their analogous
_stderr
variants) into a single method?
a

aloof-angle-91616

12/06/2019, 2:01 AM
probably not
it seems like the right thing to do
oh hm
i’m not familiar with what print() does vs .write()
@hundreds-father-404 ^
h

hundreds-breakfast-49010

12/06/2019, 2:04 AM
print
has a kwarg
end
that is by default '\n'
👍 1
write
doesn't
as far as I can tell that is the only difference
h

hundreds-father-404

12/06/2019, 2:05 AM
I remember a crazy Python 2 issue where the difference mattered. Can’t recall but I think this was in January or February from me. I’ll look tomorrow
h

hundreds-breakfast-49010

12/06/2019, 2:08 AM
if it's python 2 then we don't need to care about it anymore right?
h

hundreds-father-404

12/06/2019, 2:08 AM
(Btw this should probably go in the engine channel. It only impacts V2)
5 Views