found a subtle ordering bug in `BlockJUnit4ClassRu...
# generalf
fancy-queen-20734
03/27/2020, 7:47 PMfound a subtle ordering bug in
BlockJUnit4ClassRunnerWithRetryfancy-queen-20734
03/27/2020, 7:48 PMBlockJUnit4ClassRunner expects instantiation to happen before testStarted, but the current impl of ^^ instantiates the test after that, which broke an assumption I was making
fancy-queen-20734
03/27/2020, 8:13 PMWhile I’m poking at this, would it be neat to have flaky tests that were retried report all their failures rather than just the 1st one? @enough-analyst-54434
e
enough-analyst-54434
03/27/2020, 9:08 PMI'm bad to ask. I am ~philosophically opposed to automated flaky test re-runners.
f
fancy-queen-20734
03/28/2020, 1:28 AMlol--maybe it should just go away?
fancy-queen-20734
03/28/2020, 1:28 AMor be turned off
fancy-queen-20734
03/28/2020, 1:34 AMfwiw, pants doesn’t set retries
e
enough-analyst-54434
03/28/2020, 1:54 AMAha! I'd love for it to be killed. Since it's dead code, regardless of philosophy about the functionality, it probably should be killed anyhow.
f
fancy-queen-20734
03/28/2020, 3:30 AMnice