https://pantsbuild.org/ logo
Join Slack
Powered by
what pants invocation runs mypy in the pants repo?...
# general
f
what pants invocation runs mypy in the pants repo? (I’m looking through build-support/bin/ci.py but see nothing obvious to say what is run)
and https://travis-ci.com/github/pantsbuild/pants/jobs/352858202#L542 doesn’t display the command that was run
h
build-support/bin/mypy.py
. My current priority is to replace this with having it always activated by default via the 
lint
goal
We had to disable it by default because the v1 task would trigger a bunch of side effects that would cause v1 
lint
to fail. v2 avoids this issue
f
that would explain why my attempt to run 
./pants mypy
and `./pants lint.mypy`` failed to work
Copy code
tdyas@paradox:~/TC/pants$ build-support/bin/mypy.py
cannot import name '_is_build_file_name' from 'pants.build_graph.address' (/Users/tdyas/.venvs/3/lib/python3.7/site-packages/pants/build_graph/address.py)
NoneType: None
Please fix the above errors and run again.
h
huh, that’s weird
maybe run 
./pants clean-all
?
f
nope still same error
huh it is looking in my venv
👀 1
/Users/tdyas/.venvs/3/lib/python3.7/site-packages/pants/build_graph/address.py
h
would it be easier for me to fix and send you a diff?
f
yeah, that works for me. I just want to replicate the mypy error that was in CI …
h
Because v1 MyPy is going away today or tomorrow, I wouldn’t spend too much time on replicating
f
you mean fix the mypy error in my PR or fix this inability to run the mypy CI script?
h
fix the MyPy error in the PR
f
fine by me
4 Views
Open in Slack
PreviousNext
Powered by