https://pantsbuild.org/ logo
#general
Title
# general
m

miniature-lamp-45970

07/29/2020, 6:23 PM
In the process of upgrading to 2.0 to try it out
h

hundreds-father-404

07/29/2020, 6:24 PM
m

miniature-lamp-45970

07/29/2020, 6:56 PM
Thanks Eric. Was able to upgrade to 2.0.0.dev2 and still it hangs
But its not on tokio command as it was reported on the issue. It is on python3.7
Same behaviour with 2.0.0.dev6
h

hundreds-father-404

07/29/2020, 6:57 PM
Hm, thanks for reporting that. Are you able to share the repo, by chance, or is it private code?
m

miniature-lamp-45970

07/29/2020, 7:00 PM
I can, its just the cloned repo of pantsbuild/example-python
👍 1
@hundreds-father-404 So git cloned again to make sure any local changes are not causing the hang. Good news is, it does not cause the hang. But instead get the error, pants.backend.python.rules.run_setup_py.NoOwnerError: No exported target owner found for helloworld/protos
when running ./pants setup-py helloworld/util
h

hundreds-father-404

07/29/2020, 7:34 PM
Ah, that one is a known issue that I’ll be looking into this week. Protobuf isn’t working correctly with the
setup-py
algorithm to map libraries to distributions: https://www.pantsbuild.org/v2.0/docs/python-setup-py-goal#mapping-libraries-to-distributions Thank you for trying that out!
m

miniature-lamp-45970

07/29/2020, 7:49 PM
Thanks Eric!
h

happy-kitchen-89482

07/29/2020, 10:26 PM
Looking into the setup-py issue right now
❤️ 1
👍 1
m

miniature-lamp-45970

07/29/2020, 10:31 PM
Simplified the setup to remove the protobuf rule from example and use the setup-py on helloworld/greet and unfortunately it still hangs. Attaching the project in zip format, if you want to reproduce the issue
@happy-kitchen-89482 also created the issue https://github.com/pantsbuild/pants/issues/10508 and posted the debug logs...etc
h

happy-kitchen-89482

07/29/2020, 11:52 PM
Thanks! Looking now
m

miniature-lamp-45970

07/30/2020, 2:37 PM
Thanks for the quick resolution, will get the latest source, build from it and try it today!
h

hundreds-father-404

07/30/2020, 3:48 PM
Do you mean the latest from GitHub pantsbuild/pants? Warning that building from source can be really slow and space intensive because it involves downloading the Rust compiler and compiling the engine in Rust We plan to have a dev release tomorrow, which will include the fix for setup-py: https://github.com/pantsbuild/pants/pull/10509
m

miniature-lamp-45970

07/30/2020, 4:02 PM
Thanks Eric, I shall wait in that case.
👍 1
An update, updated the structure of sample project to make source root and build root different to test the setup-py goal. Able to generate setup.py, use editable install to install source_dist in a venv.
Couple of manual moving of files and got integration support with VSCode. 1) Moved the setup.py and Manifest.in from within the dist/${package_name}-${package_version} to build_root and then 2) pip install -e ../path_to_build_root
Caveat with this approach is, everytime a third_part deps is added to one of python_library or a new source package is added that is not listed in setup.py packages, setup.py becomes obsolete and needs updation. I can happily live with this caveat! Let me know, if there is a better approach to what am trying to do.
2 Views