i think i have a suggestion for an addition to SETTABLE_ENV_VARS: LDFLAGS, CPPFLAGS, CFLAGS (useful for pip install for example)

Good idea. We may actually want to get rid of this allowlist mechanism and allow users to set whatever they want (except for PATH and a couple of others perhaps).

yeah, it's always a trade off between allowing/forbidding

We allow setting CPPFLAGS and LDFLAGS, but it’s not intuitive how. The

[python-native-code]

subsystem: https://www.pantsbuild.org/docs/reference-python-native-code That needs to be rolled up into something more general, like

[subprocess-environment].env_vars

oh fantatic, thank you

Let us know if you need CFLAGS too. No particular reason we don’t support it

Do we set those on all processes?

No, and we likely should. Right now it’s only

PexProcess

or if you opt in as a plugin author. The reason we didn’t is that it reduces cache hits. If

count-loc

doesn’t care about

CPPFLAGS

, then sitting it will unnecessarily make the cache key less generalizable, impacting things like remote caching We punted on the design question to get out 2.0