I have non-python files (templates to send emails)...
# generalm
modern-wolf-36228
09/08/2021, 1:56 PMI have non-python files (templates to send emails). Currently they are on the MANIFEST.in and I generate the wheel with them. Now I'm building our monorepo, so... Can I include those files into the pex binary? Having them outside is not an issue, fwiw.
c
curved-television-6568
09/08/2021, 2:00 PMI’ve not used this myself, but I think what you may want is to use
resourceh
happy-kitchen-89482
09/08/2021, 2:00 PMYes, see https://www.pantsbuild.org/docs/resources#resources for how to use
resources()pkgutil😁 1
m
modern-wolf-36228
09/08/2021, 2:02 PMI've tried that, it didn't work. Let me check again.
h
happy-kitchen-89482
09/08/2021, 2:02 PMThat page has more details on the difference between
files()resources()m
modern-wolf-36228
09/08/2021, 2:14 PMah, perfect. Thanks 🙂
modern-wolf-36228
09/08/2021, 2:25 PMThis is `potato/BUILD`:
Copy code
python_library(dependencies=["./resources"])
pex_binary(
name="binary",
entry_point="__main__.py",
dependencies=["//:asyncpg", "//:python-multipart"],
) Copy code
resources(sources=["./emails"]) Copy code
resources(sources=["*.html", "./logo.png"])modern-wolf-36228
09/08/2021, 2:25 PMBut those resources are not included in the potato pex 😢
c
curved-television-6568
09/08/2021, 2:44 PMLet me replicate that, see what I get..
h
hundreds-father-404
09/08/2021, 2:48 PMDo you mean for the sources to be emails/* with a glob?
hundreds-father-404
09/08/2021, 2:51 PMAlso the dependency should be potato/resources or potato/resources:resources, not ./resources. I totally see why you're doing that - this is a bit confusing that the latter means "include a specific file" because it's a file path, whereas you want to include all the files from the resources target
c
curved-television-6568
09/08/2021, 2:54 PMIndeed, I noticed that too, but doesn’t know the details in my head like Eric 😉
so, here it is, if you run
$ ./pants dependencies --transitive :binary Copy code
Exception message: 1 Exception encountered:
InvalidSpecPath: Address spec has un-normalized path part './resources'curved-television-6568
09/08/2021, 3:02 PMSome minor tweaks, yields
Copy code
$ ./pants dependencies --transitive :binary
//__main__.py:main
resources
resources/emails/demo.html
resources/emails/logo.png Copy code
python_library(name="main", dependencies=["resources"])
pex_binary(
name="binary",
entry_point="__main__.py",
# dependencies=["//:asyncpg", "//:python-multipart"],
) Copy code
resources(sources=[], dependencies=["./emails"])pantscurved-television-6568
09/08/2021, 3:03 PMMost notable is, that I changed your
./emailscurved-television-6568
09/08/2021, 3:04 PMHowever, I’m not entirely sure about the practice of nesting resources.. perhaps that’s entirely fine? (I have no real practical experience with resources…)
m
modern-wolf-36228
09/08/2021, 3:19 PMit worked
modern-wolf-36228
09/08/2021, 3:20 PMThanks!
modern-wolf-36228
09/08/2021, 3:21 PMThe knowledge missing was the right "dependencies path", and the sources being empty on the
resources/BUILDmodern-wolf-36228
09/08/2021, 3:21 PMthanks @curved-television-6568 and @hundreds-father-404
❤️ 1
w
witty-crayon-22786
09/08/2021, 4:01 PMthat’s an interesting edge case… we warn if globs aren’t matched. but that glob was matched… just not recursively.
👍 1
witty-crayon-22786
09/08/2021, 4:01 PMthe effect was an empty directory being included.
m
modern-wolf-36228
09/08/2021, 4:02 PMI didn't see any empty directory with my snippet above
modern-wolf-36228
09/08/2021, 4:02 PM(extracting the content of pex)
w
witty-crayon-22786
09/08/2021, 4:02 PModd.
6 Views