restartable doesn t work with uvicorn in the expected way mo

Question

restartable doesn t work with uvicorn in the expected way more on thread

modern-wolf-36228 · Answer

`uvicorn` shutdown behavior is the following If you send `SIGTERM` or `SIGINT` it will set a variable `should exit` to True and it will start the graceful shutdown If you send another `SIGTERM` or `SIGINT` it will set a variable `force exit` to True and it will force the exit

modern-wolf-36228 · Answer

for what I m seeing `uvicorn` is receiving two signals due to that it cannot shutdown gracefully thinking face

curved-television-6568 · Answer

Perhaps there should be a shutdown grace period timeout that ll dictate how long we should expect to wait for a process to die cleanly before killing it Not sure if that s relevant here but perhaps could come in handy in case a process is a bit slow to shutdown < witty crayon 22786>

modern-wolf-36228 · Answer

the thing is that this process that I m running doesn t take time to shutdown but the double signal doesn t give that opportunity

modern-wolf-36228 · Answer

doesn t take time = the timeout shouldn t matter

curved-television-6568 · Answer

Yeah sorry for hi jacking the thread I just realized that this could be an edge case to consider

curved-television-6568 · Answer

Double signals seems like a bug

witty-crayon-22786 · Answer

interesting i m surprised you get more than one signal if anything i would think that you got only `SIGKILL`

witty-crayon-22786 · Answer

which two signals are you seeing

modern-wolf-36228 · Answer

ah ok that can be as well

modern-wolf-36228 · Answer

So why are we sending `SIGKILL`

modern-wolf-36228 · Answer

can I control this behavior thinking face

witty-crayon-22786 · Answer

mostly because it s the only signal you don t really need to wait for a response to but if it s valuable to send TERM in this case i can look at that

witty-crayon-22786 · Answer

i ll probably see if there is any sort of convention or standard that we should be following here i know that TERM wait a bit then KILL is a convention

witty-crayon-22786 · Answer

would that work for your needs

modern-wolf-36228 · Answer

sorry I didn t see the suggestion on your words thinking face You mean sending TERM waiting x and then KILL

witty-crayon-22786 · Answer

right

modern-wolf-36228 · Answer

yep that would be perfect +1

modern-wolf-36228 · Answer

ppl may want to configure the timeout or not have this behavior tho not sure thinking face

witty-crayon-22786 · Answer

yea hopefully that s not a per binary setting

witty-crayon-22786 · Answer

< modern wolf 36228> to help me understand priority what is the impact of `uvicorn` being killed like this does it fail to restart or just fail to clean up files processes it created

modern-wolf-36228 · Answer

it doesn t run what we call a shutdown event it s basically a function defined by the user that is called when uvicorn is asked to shutdown

modern-wolf-36228 · Answer

it restarts ok the way it is

modern-wolf-36228 · Answer

so it can clean up many things what specifically is defined by the user

witty-crayon-22786 · Answer

got it

witty-crayon-22786 · Answer

modern-wolf-36228 · Answer

cool thanks +1