https://pantsbuild.org/ logo
#general
Title
# general
d

dazzling-diamond-4749

11/16/2021, 4:40 AM
Any sharp edges to watch out for when upgrading from 2.6 -> 2.8rc5? We want to test out the experimental bash target and golang support.
h

happy-kitchen-89482

11/16/2021, 5:23 AM
I'd recommend upgrading to 2.7.1 first so you can see any deprecation messages that apply to your codebase, and from there to 2.8.0rc5
h

hundreds-father-404

11/16/2021, 5:50 AM
h

high-energy-55500

11/16/2021, 2:33 PM
side note here: i’m currently playing around with upgrading from 2.7.0 to 2.8.0rc5, and I’ve encountered a few import errors because of classes that got dropped and method names that got changed. I may have missed it, but i don’t recall seeing any deprecation warnings in 2.7.0 for example: •
pants.engine.process.InteractiveRunner
got dropped •
pants.core.target_types.FilesSources
got dropped and replaced with
FilesGeneratingSourcesField
pants.backend.python.target_types.PythonSources
got dropped and replaced with
PythonGeneratingSourcesBase
and
PythonSourceField
pants.build_graph.address.Address
had a
.maybe_convert_to_build_target()
method that got renamed to
.maybe_convert_to_generated_target()
did these changes not get deprecation notices or were they only added in 2.7.1?
h

happy-kitchen-89482

11/16/2021, 3:04 PM
Ah, sorry for that inconvenience! We don't consider the plugin API to be completely stable yet, so we don't do formal deprecations there yet.
👍 1
h

high-energy-55500

11/16/2021, 3:09 PM
good to know, thanks!
h

hundreds-father-404

11/16/2021, 3:13 PM
Sounds like this won't be helpful for you rn because you already fixed the issues, but we do have a plugin migration guide that I'll be updating today
h

high-energy-55500

11/16/2021, 5:53 PM
@hundreds-father-404 that sounds great, lmk when that’s done so i can go over it to make sure i didn’t miss anything 🙂
3 Views