https://pantsbuild.org/ logo
Powered by
m

modern-wolf-36228

11/30/2021, 12:50 PM
Are there plans to create CLI shortcuts like 
--no-process-execution-local-cleanup
-> 
-n
? 😗
c

curved-television-6568

11/30/2021, 12:58 PM
you can add that to your own 
pants.toml
I was going to say… but it seems that the alias feature does not work for engine flags.. (as it had no effect for me.. if that is what it was)
Well, that err was behind the keyboard. It works to do
Copy code
# pants.toml
[cli.alias]
keep-tmpdirs = "--no-process-execution-local-cleanup"
And so does,
Copy code
$ alias pants-dbg="./pants --no-process-execution-local-cleanup"
(at least in a bash shell..)
n.b. pants cli aliases may not look like flags, so can’t begin with 
-
..
👍 1
h

happy-kitchen-89482

11/30/2021, 1:39 PM
In specific cases that are universally useful we can create hardwired shortcuts in the code, but I imagine it would be hard to come to consensus on what those should be... Hopefully the alias functionality will serve?
h

hundreds-father-404

11/30/2021, 2:21 PM
I would also still like to rename the option to be --no-process-cleanup. We lose namespacing with other --process-execution args like --process-execution-local-parallelism. But because this cleanup option should be set via CLI arg rather than config file, I don't think that actually matters. You're not usually specifying those other options at the same time with CLI; namespacing doesn't buy us much
Should also be 
--no-local-cache
instead of 
--no-process-execution-local-cache
imo
c

curved-television-6568

12/01/2021, 4:55 PM
shouldn’t it be 
--no-process-cache
? otherwise there’s no symmetry in what parts are dropped from the existing flags.. 😉
h

hundreds-father-404

12/01/2021, 4:59 PM
I don't think so. We have 
--remote-cache-{read,write}
, so it's important that we distinguish between local vs remote here. Whereas with "cleanup", I don't think that's very relevant to disambiguate We could say 
--no-process-local-cache
. But that's more verbose and we don't include 
process
with the 
--remote
options
That is, symmetry is the wrong goal here
👍 1
c

curved-television-6568

12/01/2021, 5:09 PM
Well, I think symmetry is still at play, only it has more inputs than what I was looking at here 🙂
(and that some options that already are implemented, may be so asymmetrically..) 😉
👍 1
h

hundreds-father-404

12/01/2021, 7:21 PM
https://github.com/pantsbuild/pants/pull/13769 @modern-wolf-36228 feel free to weigh in directly on that PR 🙂 Thanks for the feedback!
🙌 1
Powered by